Skip to content

Refactor: Remove redundant else in get_activation #42554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
+2 −2
Open

Refactor: Remove redundant else in get_activation #42554

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
29127ad
Refactor: Remove redundant else in get_activation
leaderofARS Dec 2, 2025
3831d2d
style: apply code quality fixes
leaderofARS Dec 2, 2025
e3424ea
Merge branch 'main' into fix-redundant-else
leaderofARS Dec 3, 2025
8bf15c6
Merge branch 'main' into fix-redundant-else
leaderofARS Dec 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/transformers/activations.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,8 +345,8 @@ def forward(self, input: Tensor) -> Tensor:
def get_activation(activation_string):
if activation_string in ACT2FN:
return ACT2FN[activation_string]
else:
raise KeyError(f"function {activation_string} not found in ACT2FN mapping {list(ACT2FN.keys())}")

raise KeyError(f"function {activation_string} not found in ACT2FN mapping {list(ACT2FN.keys())}")


# For backwards compatibility with: from activations import gelu_python
Expand Down