grpc: use pointers for load_balancing::WeakSubchannel hash/eq operations #2439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Promoting to Arc<dyn Subchannel> before performing these operations is more expensive. Just using the pointer is simpler and quicker.
LucioFranco
reviewed
Nov 6, 2025
| return strong.dyn_hash(&mut Box::new(state as &mut dyn Hasher)); | ||
| } | ||
| panic!("WeakSubchannel is not valid"); | ||
| (self.0.as_ptr() as *const () as usize).hash(state); |
There was a problem hiding this comment.
this feels really weird but I guess its okay lol
LucioFranco
approved these changes
Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an old change that I found in my client that never got pushed upstream, but is worth having.
Upgrading weak to owned before performing these operations is more expensive. Just using the pointer is simpler and quicker and equally valid.