Skip to content

grpc: use pointers for load_balancing::WeakSubchannel hash/eq operations #2439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 6, 2025
Merged

grpc: use pointers for load_balancing::WeakSubchannel hash/eq operations #2439

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 3 additions & 10 deletions grpc/src/client/load_balancing/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ use std::{
fmt::{Debug, Display},
hash::{Hash, Hasher},
ops::{Add, Sub},
ptr::addr_eq,
sync::{
atomic::{AtomicI64, Ordering::Relaxed},
Arc, Mutex, Weak,
Expand Down Expand Up @@ -456,21 +457,13 @@ impl WeakSubchannel {

impl Hash for WeakSubchannel {
fn hash<H: Hasher>(&self, state: &mut H) {
if let Some(strong) = self.upgrade() {
return strong.dyn_hash(&mut Box::new(state as &mut dyn Hasher));
}
panic!("WeakSubchannel is not valid");
(self.0.as_ptr() as *const () as usize).hash(state);
Copy link
Member

@LucioFranco LucioFranco Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this feels really weird but I guess its okay lol

}
}

impl PartialEq for WeakSubchannel {
fn eq(&self, other: &Self) -> bool {
if let Some(strong_self) = self.upgrade() {
if let Some(strong_other) = other.upgrade() {
return strong_self.dyn_eq(&Box::new(&strong_other as &dyn Any));
}
}
false
addr_eq(self.0.as_ptr(), other.0.as_ptr())
}
}

Expand Down
Loading