Skip to content

Conversation

@boinq
Copy link

@boinq boinq commented Nov 16, 2025

Describe your PR, what does it fix/add?
This PR adds Danish language translations

Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
None

Is it ready for merging, or does it need work?
Yes. The translations are finished.

@github-actions github-actions bot added the core label Nov 16, 2025
@vaxerski
Copy link
Member

ai, please recheck

@boinq
Copy link
Author

boinq commented Nov 16, 2025

ai? this isn't AI, what's the problem?

@vaxerski
Copy link
Member

I am working on an ai bot to check translations but it worked on my private repo but is throwing a tantrum here dw

@boinq
Copy link
Author

boinq commented Nov 16, 2025

ah, okay no worries

@vaxerski
Copy link
Member

ai, please recheck

@github-actions
Copy link

AI translation check result:

Translation check not ok

  • TXT_KEY_NOTIF_FAILED_ASSETS

    • Offending text: "Hyprland kunne ikke indlæse {count} essentiale aktiver, skyd skylden på din distributions pakker for et dårligt stykke arbejde af pakningen!"
    • Reason: Unprofessional/insulting tone ("skyd skylden på din distributions pakker...") and multiple grammatical/spelling errors ("essentiale" -> "essentielle", "distributions pakker" -> "distributionspakkerne" etc.). Should be rewritten in a neutral, correct Danish.
  • TXT_KEY_NOTIF_NO_GUIUTILS

    • Offending text: "Dit system har ikke hyprland-guiutils indstalleret."
    • Reason: Spelling error: "indstalleret" should be "installeret".
  • TXT_KEY_PERMISSION_REQUEST_KEYBOARD

    • Offending text: "Et nyt keyboard er fundet: {keyboard}.\n\nVil du tillade den at fungere?"
    • Reason: Grammatical mismatch/pronoun error — "keyboard" (et) should be referred to as "det" (or use Danish "tastatur" and adjust accordingly).
  • TXT_KEY_NOTIF_INVALID_MONITOR_LAYOUT

    • Offending text: "Din skærms layout har en ukorrekt opsætning. Skærm {name} overlapper med andre skærm(e) i layoutet.\nLæs venligst wiki'en (Skærm side) for mere. Dette vil skabe problemer."
    • Reason: Awkward phrasing and punctuation ("Din skærms layout" → "Skærmens layout" or "Dit skærmlayout"; "wiki'en (Skærm side)" should be e.g. "wiki'en (Skærmside)").

@vaxerski
Copy link
Member

finally, works :)

@boinq
Copy link
Author

boinq commented Nov 16, 2025

Nice! Do you want me to correct it following what it's saying? Because i slightly disagree with some of the suggestions

@vaxerski
Copy link
Member

if you disagree it's fine, but I see typos so those should probably be fixed.

the purpose of the ci job is twofold:

  • help the translator catch small mistakes (e.g. typos)
  • let me know you ain't trying to sneak in a troll translation

@boinq
Copy link
Author

boinq commented Nov 16, 2025

Makes sense, i'll definitely correct the spelling mistake.
And the unprofessional phrasing was taken from your original text :)

@vaxerski
Copy link
Member

And the unprofessional phrasing was taken from your original text :)

that's why I'm saying AI is a guideline and not a hard requirement xD

vaxerski
vaxerski previously approved these changes Nov 16, 2025
Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@boinq
Copy link
Author

boinq commented Nov 16, 2025

You're welcome!

@vaxerski
Copy link
Member

clang-format needed

@boinq
Copy link
Author

boinq commented Nov 16, 2025

i'm hoping that did it, i don't code C++ myself

@vaxerski
Copy link
Member

just run clang-format -i src/**/*{cpp,hpp} from the repo root :P

Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants