-
Notifications
You must be signed in to change notification settings - Fork 1.2k
🌱 Bump the k8s.io/* deps to v0.35.0-alpha.1 #3349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+202
−203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thx! /lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
LGTM label has been added. Git tree hash: 15f238cca8e9dcf6a3eb2daa714244345a77f397
|
13 tasks
damemi
added a commit
to odigos-io/odigos
that referenced
this pull request
Oct 13, 2025
## Description Some CI are failing like https://github.com/odigos-io/odigos/actions/runs/18466376700/job/52609233046?pr=3610#step:6:97 ``` mkdir -p /home/runner/work/odigos/odigos/instrumentor/bin GOBIN=/home/runner/work/odigos/odigos/instrumentor/bin go install sigs.k8s.io/controller-runtime/tools/setup-envtest@latest go: downloading sigs.k8s.io/controller-runtime/tools/setup-envtest v0.0.0-20251013122658-1ad089b0ee87 go: downloading sigs.k8s.io/controller-runtime v0.22.3 go: sigs.k8s.io/controller-runtime/tools/setup-envtest@latest: sigs.k8s.io/controller-runtime/tools/[email protected] requires go >= 1.25.0 (running go 1.24.0; GOTOOLCHAIN=local) make: *** [Makefile:67: /home/runner/work/odigos/odigos/instrumentor/bin/setup-envtest] Error 1 ``` This started because controller-runtime bumped setup-envtest to 1.25 yesterday and we check it out from latest kubernetes-sigs/controller-runtime#3349 This pins the tool to the most recent commit without including the 1.25 bump ## How Has This Been Tested? <!-- Describe the tests you ran and how you verified your changes. --> - [ ] Added Unit Tests - [ ] Updated e2e Tests - [ ] Manual Testing - [ ] Manual Load Test ## Kubernetes Checklist <!-- If this PR affects how Odigos interacts with Kubernetes, check the relevant boxes below and provide more details --> - [ ] Changes how Odigos interacts with Kubernetes - [ ] Introduces additional calls to the API Server (potential performance impact) - [ ] New Query/feature supported in all the k8s versions supported by Odigos - [ ] Modifies Odigos manifests (addressed in both CLI and Helm) - [ ] Changes RBAC permissions ## User Facing Changes <!-- Any changes that users will notice or need to be aware of --> - [ ] Users need to take action before upgrading - [ ] Automatic migration will modify existing objects (backward compatible) - [ ] Changes UI, CLI, or K8s Manifests aspects in a way that users need to be aware of - [ ] Documentation updated accordingly
rabi
added a commit
to rabi/openstack-operator
that referenced
this pull request
Oct 14, 2025
kubernetes-sigs/controller-runtime#3349 has updated golang to 1.25 in controller-runtime. Signed-off-by: rabi <[email protected]>
rabi
added a commit
to rabi/openstack-operator
that referenced
this pull request
Oct 14, 2025
kubernetes-sigs/controller-runtime#3349 has updated golang to 1.25 in controller-runtime. Signed-off-by: rabi <[email protected]>
rabi
added a commit
to rabi/openstack-operator
that referenced
this pull request
Oct 14, 2025
kubernetes-sigs/controller-runtime#3349 has updated golang to 1.25 in controller-runtime. Signed-off-by: rabi <[email protected]>
dprince
added a commit
to dprince/keystone-operator
that referenced
this pull request
Oct 14, 2025
kubernetes-sigs/controller-runtime#3349 has updated golang to 1.25 in controller-runtime.
dprince
added a commit
to dprince/barbican-operator
that referenced
this pull request
Oct 14, 2025
kubernetes-sigs/controller-runtime#3349 has updated golang to 1.25 in controller-runtime.
dprince
added a commit
to dprince/barbican-operator
that referenced
this pull request
Oct 14, 2025
kubernetes-sigs/controller-runtime#3349 has updated golang to 1.25 in controller-runtime.
dprince
added a commit
to dprince/cinder-operator
that referenced
this pull request
Oct 14, 2025
kubernetes-sigs/controller-runtime#3349 has updated golang to 1.25 in controller-runtime.
dprince
added a commit
to dprince/designate-operator
that referenced
this pull request
Oct 14, 2025
kubernetes-sigs/controller-runtime#3349 has updated golang to 1.25 in controller-runtime.
dprince
added a commit
to dprince/glance-operator
that referenced
this pull request
Oct 14, 2025
kubernetes-sigs/controller-runtime#3349 has updated golang to 1.25 in controller-runtime.
dprince
added a commit
to dprince/heat-operator
that referenced
this pull request
Oct 14, 2025
kubernetes-sigs/controller-runtime#3349 has updated golang to 1.25 in controller-runtime.
abays
added a commit
to abays/swift-operator
that referenced
this pull request
Oct 15, 2025
kubernetes-sigs/controller-runtime#3349 has updated golang to 1.25 in controller-runtime. Signed-off-by: Claude AI Assistant <[email protected]>
abays
added a commit
to abays/telemetry-operator
that referenced
this pull request
Oct 15, 2025
kubernetes-sigs/controller-runtime#3349 has updated golang to 1.25 in controller-runtime. Co-Authored-By: Claude Assistant <[email protected]>
openshift-cherrypick-robot
pushed a commit
to openshift-cherrypick-robot/openstack-baremetal-operator
that referenced
this pull request
Oct 15, 2025
kubernetes-sigs/controller-runtime#3349 has updated golang to 1.25 in controller-runtime. Co-authored-by: Claude <[email protected]>
abays
pushed a commit
to openshift-cherrypick-robot/glance-operator
that referenced
this pull request
Oct 15, 2025
kubernetes-sigs/controller-runtime#3349 has updated golang to 1.25 in controller-runtime.
abays
pushed a commit
to openshift-cherrypick-robot/glance-operator
that referenced
this pull request
Oct 15, 2025
kubernetes-sigs/controller-runtime#3349 has updated golang to 1.25 in controller-runtime.
openshift-cherrypick-robot
pushed a commit
to openshift-cherrypick-robot/telemetry-operator
that referenced
this pull request
Oct 15, 2025
kubernetes-sigs/controller-runtime#3349 has updated golang to 1.25 in controller-runtime. Co-Authored-By: Claude Assistant <[email protected]>
openshift-cherrypick-robot
pushed a commit
to openshift-cherrypick-robot/ovn-operator
that referenced
this pull request
Oct 15, 2025
kubernetes-sigs/controller-runtime#3349 has updated golang to 1.25 in controller-runtime.
openshift-merge-bot bot
pushed a commit
to openstack-k8s-operators/placement-operator
that referenced
this pull request
Oct 16, 2025
kubernetes-sigs/controller-runtime#3349 has updated golang to 1.25 in controller-runtime. Co-authored-by: Claude <[email protected]>
openshift-cherrypick-robot
pushed a commit
to openshift-cherrypick-robot/placement-operator
that referenced
this pull request
Oct 16, 2025
kubernetes-sigs/controller-runtime#3349 has updated golang to 1.25 in controller-runtime. Co-authored-by: Claude <[email protected]>
openshift-cherrypick-robot
pushed a commit
to openshift-cherrypick-robot/swift-operator
that referenced
this pull request
Oct 16, 2025
kubernetes-sigs/controller-runtime#3349 has updated golang to 1.25 in controller-runtime. Signed-off-by: Claude AI Assistant <[email protected]>
openshift-merge-bot bot
pushed a commit
to openstack-k8s-operators/placement-operator
that referenced
this pull request
Oct 16, 2025
kubernetes-sigs/controller-runtime#3349 has updated golang to 1.25 in controller-runtime. Co-authored-by: Claude <[email protected]>
openshift-cherrypick-robot
pushed a commit
to openshift-cherrypick-robot/neutron-operator
that referenced
this pull request
Oct 16, 2025
kubernetes-sigs/controller-runtime#3349 has updated golang to 1.25 in controller-runtime.
mrkisaolamb
pushed a commit
to dprince/nova-operator
that referenced
this pull request
Oct 20, 2025
kubernetes-sigs/controller-runtime#3349 has updated golang to 1.25 in controller-runtime.
openshift-merge-bot bot
pushed a commit
to openstack-k8s-operators/nova-operator
that referenced
this pull request
Oct 22, 2025
kubernetes-sigs/controller-runtime#3349 has updated golang to 1.25 in controller-runtime.
openshift-cherrypick-robot
pushed a commit
to openshift-cherrypick-robot/nova-operator
that referenced
this pull request
Oct 22, 2025
kubernetes-sigs/controller-runtime#3349 has updated golang to 1.25 in controller-runtime.
openshift-merge-bot bot
pushed a commit
to openstack-k8s-operators/nova-operator
that referenced
this pull request
Oct 22, 2025
kubernetes-sigs/controller-runtime#3349 has updated golang to 1.25 in controller-runtime.
elfiesmelfie
pushed a commit
to elfiesmelfie/telemetry-operator
that referenced
this pull request
Oct 29, 2025
kubernetes-sigs/controller-runtime#3349 has updated golang to 1.25 in controller-runtime. Co-Authored-By: Claude Assistant <[email protected]>
stuggi
added a commit
to stuggi/osp-director-operator
that referenced
this pull request
Nov 6, 2025
kubernetes-sigs/controller-runtime#3349 has updated golang to 1.25 in controller-runtime. Signed-off-by: Martin Schuppert <[email protected]>
stuggi
added a commit
to stuggi/osp-director-operator
that referenced
this pull request
Nov 7, 2025
kubernetes-sigs/controller-runtime#3349 has updated golang to 1.25 in controller-runtime. Signed-off-by: Martin Schuppert <[email protected]>
stuggi
added a commit
to stuggi/osp-director-operator
that referenced
this pull request
Nov 7, 2025
kubernetes-sigs/controller-runtime#3349 has updated golang to 1.25 in controller-runtime. Signed-off-by: Martin Schuppert <[email protected]>
stuggi
added a commit
to stuggi/osp-director-operator
that referenced
this pull request
Nov 7, 2025
kubernetes-sigs/controller-runtime#3349 has updated golang to 1.25 in controller-runtime. Signed-off-by: Martin Schuppert <[email protected]>
stuggi
added a commit
to stuggi/osp-director-operator
that referenced
this pull request
Nov 7, 2025
kubernetes-sigs/controller-runtime#3349 has updated golang to 1.25 in controller-runtime. Signed-off-by: Martin Schuppert <[email protected]>
stuggi
added a commit
to stuggi/osp-director-operator
that referenced
this pull request
Nov 7, 2025
kubernetes-sigs/controller-runtime#3349 has updated golang to 1.25 in controller-runtime. Signed-off-by: Martin Schuppert <[email protected]>
stuggi
added a commit
to stuggi/osp-director-operator
that referenced
this pull request
Nov 10, 2025
kubernetes-sigs/controller-runtime#3349 has updated golang to 1.25 in controller-runtime. Signed-off-by: Martin Schuppert <[email protected]>
stuggi
added a commit
to stuggi/osp-director-operator
that referenced
this pull request
Nov 11, 2025
kubernetes-sigs/controller-runtime#3349 has updated golang to 1.25 in controller-runtime. Signed-off-by: Martin Schuppert <[email protected]>
stuggi
added a commit
to stuggi/osp-director-operator
that referenced
this pull request
Nov 12, 2025
kubernetes-sigs/controller-runtime#3349 has updated golang to 1.25 in controller-runtime. Signed-off-by: Martin Schuppert <[email protected]> (cherry picked from commit 1bfb286)
stuggi
added a commit
to stuggi/osp-director-operator
that referenced
this pull request
Nov 12, 2025
kubernetes-sigs/controller-runtime#3349 has updated golang to 1.25 in controller-runtime. Signed-off-by: Martin Schuppert <[email protected]> (cherry picked from commit 1bfb286)
stuggi
added a commit
to stuggi/osp-director-operator
that referenced
this pull request
Nov 19, 2025
kubernetes-sigs/controller-runtime#3349 has updated golang to 1.25 in controller-runtime. Signed-off-by: Martin Schuppert <[email protected]> (cherry picked from commit 1bfb286)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.