-
Notifications
You must be signed in to change notification settings - Fork 450
v1beta2: Remove deprecated retryDelayMinutes field #7407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v1beta2: Remove deprecated retryDelayMinutes field #7407
Conversation
|
Hi @nerdeveloper. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
|
/ok-to-test |
|
To fix linter you can use command |
32241db to
a9735de
Compare
|
/retest |
test/integration/singlecluster/webhook/core/admissioncheck_test.go
Outdated
Show resolved
Hide resolved
|
/retest |
|
@nerdeveloper please rebase, it looks almost ready to go |
b14fca0 to
ac8aa64
Compare
|
what is the lint issue, when i try the command, i get this find . -path ./site -prune -false -o -name go.mod -exec dirname {} \; | xargs -I {} sh -c 'cd "{}" && /Users/odirionye/Documents/go/src/github.com/nerdeveloper/kueue/bin/golangci-lint run --fix --timeout 15m0s --config "/Users/odirionye/Documents/go/src/github.com/nerdeveloper/kueue/.golangci.yaml"'
Error: can't load config: the Go language version (go1.24) used to build golangci-lint is lower than the targeted Go version (1.25.0)
The command is terminated due to an error: can't load config: the Go language version (go1.24) used to build golangci-lint is lower than the targeted Go version (1.25.0)
Error: can't load config: the Go language version (go1.24) used to build golangci-lint is lower than the targeted Go version (1.25.0)
The command is terminated due to an error: can't load config: the Go language version (go1.24) used to build golangci-lint is lower than the targeted Go version (1.25.0)
Error: can't load config: the Go language version (go1.24) used to build golangci-lint is lower than the targeted Go version (1.25.0)
The command is terminated due to an error: can't load config: the Go language version (go1.24) used to build golangci-lint is lower than the targeted Go version (1.25.0)
make: *** [ci-lint] Error 1 |
I think you need to upgrade golang version. |
test/integration/singlecluster/webhook/core/admissioncheck_test.go
Outdated
Show resolved
Hide resolved
|
@nerdeveloper please update the PR |
|
I think you need to rebase again. Recently there have been many PRs related to v1beta2 so it is moving fast in this area |
|
i thkink i have messed up my git cos not sure why i am seeing 2018 changes |
|
yeah something looks odd, maybe redo from clean main branch |
48e59d7 to
7103484
Compare
- Remove retryDelayMinutes field from AdmissionCheckSpec in v1beta2 - Add conversion function for AdmissionCheckSpec from v1beta1 to v1beta2 - Update CRD, generated code, and documentation - Update integration tests to reflect changes
7103484 to
8fb45ff
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mimowo, nerdeveloper The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM label has been added. Git tree hash: 295c8b6904943ae867b6bb5f3300b017f4dc8467
|
…kubernetes-sigs#7407) - Remove retryDelayMinutes field from AdmissionCheckSpec in v1beta2 - Add conversion function for AdmissionCheckSpec from v1beta1 to v1beta2 - Update CRD, generated code, and documentation - Update integration tests to reflect changes
What type of PR is this?
/kind cleanup
/kind api-change
/kind deprecation
What this PR does / why we need it:
This PR removes the long-deprecated retryDelayMinutes field from Kueue's v1beta2 AdmissionCheckSpec. The retryDelayMinutes field has been deprecated since v0.8 and was unused, providing no functionality.
Technical changes:
RetryDelayMinutesfield from v1beta2 AdmissionCheckSpecMigration note: The field remains available in v1beta1 for backward compatibility.
Which issue(s) this PR fixes:
Part of #7247
Does this PR introduce a user-facing change?