Skip to content

Conversation

@nerdeveloper
Copy link
Contributor

What type of PR is this?

/kind cleanup
/kind api-change
/kind deprecation

What this PR does / why we need it:

This PR removes the long-deprecated retryDelayMinutes field from Kueue's v1beta2 AdmissionCheckSpec. The retryDelayMinutes field has been deprecated since v0.8 and was unused, providing no functionality.

Technical changes:

  • Remove RetryDelayMinutes field from v1beta2 AdmissionCheckSpec
  • Update conversion functions to ignore retryDelayMinutes field during v1beta1 to v1beta2 conversion
  • Update test to remove retryDelayMinutes usage
  • Regenerate deepcopy, conversion code, and CRD manifests

Migration note: The field remains available in v1beta1 for backward compatibility.

Which issue(s) this PR fixes:

Part of #7247

Does this PR introduce a user-facing change?

Remove deprecated retryDelayMinutes field from v1beta2 AdmissionCheckSpec. This field was deprecated since v0.8 and provided no functionality. Users using v1beta1 are unaffected.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. labels Oct 27, 2025
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 27, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @nerdeveloper. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 27, 2025
@netlify
Copy link

netlify bot commented Oct 27, 2025

Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit 8fb45ff
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-kueue/deploys/69049ad4f11d3900081197a8

@mimowo
Copy link
Contributor

mimowo commented Oct 27, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 27, 2025
@mbobrovskyi
Copy link
Contributor

To fix linter you can use command make lint-fix

@nerdeveloper nerdeveloper force-pushed the remove-retrydelayminutes-v1beta2 branch from 32241db to a9735de Compare October 27, 2025 12:15
@nerdeveloper
Copy link
Contributor Author

/retest

@PBundyra
Copy link
Contributor

/retest

@mimowo
Copy link
Contributor

mimowo commented Oct 29, 2025

@nerdeveloper please rebase, it looks almost ready to go

@nerdeveloper nerdeveloper force-pushed the remove-retrydelayminutes-v1beta2 branch from b14fca0 to ac8aa64 Compare October 29, 2025 15:34
@nerdeveloper
Copy link
Contributor Author

what is the lint issue, when i try the command, i get this

find . -path ./site -prune -false -o -name go.mod -exec dirname {} \; | xargs -I {} sh -c 'cd "{}" && /Users/odirionye/Documents/go/src/github.com/nerdeveloper/kueue/bin/golangci-lint run --fix --timeout 15m0s --config "/Users/odirionye/Documents/go/src/github.com/nerdeveloper/kueue/.golangci.yaml"'
Error: can't load config: the Go language version (go1.24) used to build golangci-lint is lower than the targeted Go version (1.25.0)
The command is terminated due to an error: can't load config: the Go language version (go1.24) used to build golangci-lint is lower than the targeted Go version (1.25.0)
Error: can't load config: the Go language version (go1.24) used to build golangci-lint is lower than the targeted Go version (1.25.0)
The command is terminated due to an error: can't load config: the Go language version (go1.24) used to build golangci-lint is lower than the targeted Go version (1.25.0)
Error: can't load config: the Go language version (go1.24) used to build golangci-lint is lower than the targeted Go version (1.25.0)
The command is terminated due to an error: can't load config: the Go language version (go1.24) used to build golangci-lint is lower than the targeted Go version (1.25.0)
make: *** [ci-lint] Error 1

@mbobrovskyi
Copy link
Contributor

what is the lint issue, when i try the command, i get this

I think you need to upgrade golang version.

@mimowo
Copy link
Contributor

mimowo commented Oct 31, 2025

@nerdeveloper please update the PR

@mimowo
Copy link
Contributor

mimowo commented Oct 31, 2025

I think you need to rebase again. Recently there have been many PRs related to v1beta2 so it is moving fast in this area

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 31, 2025
@nerdeveloper
Copy link
Contributor Author

i thkink i have messed up my git cos not sure why i am seeing 2018 changes

@mimowo
Copy link
Contributor

mimowo commented Oct 31, 2025

yeah something looks odd, maybe redo from clean main branch

@nerdeveloper nerdeveloper force-pushed the remove-retrydelayminutes-v1beta2 branch from 48e59d7 to 7103484 Compare October 31, 2025 10:42
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 31, 2025
- Remove retryDelayMinutes field from AdmissionCheckSpec in v1beta2
- Add conversion function for AdmissionCheckSpec from v1beta1 to v1beta2
- Update CRD, generated code, and documentation
- Update integration tests to reflect changes
@nerdeveloper nerdeveloper force-pushed the remove-retrydelayminutes-v1beta2 branch from 7103484 to 8fb45ff Compare October 31, 2025 11:17
@mimowo
Copy link
Contributor

mimowo commented Oct 31, 2025

/lgtm
/approve
/test pull-kueue-test-e2e-main-1-31
this is a known flake, currently being worked on under #7479

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 31, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mimowo, nerdeveloper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 295c8b6904943ae867b6bb5f3300b017f4dc8467

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 31, 2025
@k8s-ci-robot k8s-ci-robot merged commit e570668 into kubernetes-sigs:main Oct 31, 2025
23 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.15 milestone Oct 31, 2025
@nerdeveloper nerdeveloper deleted the remove-retrydelayminutes-v1beta2 branch October 31, 2025 13:20
Singularity23x0 pushed a commit to Singularity23x0/kueue that referenced this pull request Nov 3, 2025
…kubernetes-sigs#7407)

- Remove retryDelayMinutes field from AdmissionCheckSpec in v1beta2
- Add conversion function for AdmissionCheckSpec from v1beta1 to v1beta2
- Update CRD, generated code, and documentation
- Update integration tests to reflect changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants