Skip to content

Switch Default TAS Placement Algorithm from BestFit to Mixed. #7416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 4, 2025
Merged

Switch Default TAS Placement Algorithm from BestFit to Mixed. #7416

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
787d538
Enable TAS Mixed Profile for default
iomarsayed Oct 28, 2025
09ac41a
adjust feature and kep
iomarsayed Nov 3, 2025
07bbf53
remove deprecation of current version for TASProfileMixed
iomarsayed Nov 3, 2025
f9ea38f
cleanups
iomarsayed Nov 3, 2025
94a293e
fix typo
iomarsayed Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions keps/2724-topology-aware-scheduling/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1072,11 +1072,11 @@ Since v0.15, the available feature gates are as follows:

| feature gate / annotation | preferred | required | unconstrained |
| ------------------------------------------ | ----------------- | ----------------- | ----------------- |
| None <br/> or TASProfileMixed (deprecated) | BestFit | BestFit | LeastFreeCapacity |
| None <br/> or TASProfileMixed (default) | BestFit | BestFit | LeastFreeCapacity |
| TASProfileBestFit (deprecated) | BestFit | BestFit | BestFit |
| TASProfileLeastFreeCapacity (deprecated) | LeastFreeCapacity | LeastFreeCapacity | LeastFreeCapacity |

Based on the user feedback, we decided to make `TASProfileMixed` default. (The corresponding feature gate is hence obsolete; we formally keep it "deprecated" for backwards compatibility). It differs from the previous default only in the `unconstrained` case - in which Kueue should prioritize minimizing fragmentation which is provided by the `LeastFreeCapacity` algorithm.
Based on the user feedback, we decided to make `TASProfileMixed` default starting in v0.15. (The corresponding feature gate is hence obsolete; we formally keep it "deprecated" for backwards compatibility). It differs from the previous default only in the `unconstrained` case - in which Kueue should prioritize minimizing fragmentation which is provided by the `LeastFreeCapacity` algorithm.

For users still preferring the "always BestFit" profile, we introduce the `TASProfileBestFit` feature gate, marking it as deprecated. We will remove it in v0.17 if we see no report indicating a need for that configuration.

Expand Down
34 changes: 10 additions & 24 deletions pkg/cache/scheduler/tas_cache_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -658,18 +658,11 @@ func TestFindTopologyAssignments(t *testing.T) {
wantAssignment: &kueue.TopologyAssignment{
Levels: defaultOneLevel,
Domains: []kueue.TopologyDomainAssignment{
{
Count: 4,
Values: []string{
"x3",
},
},
{
Count: 2,
Values: []string{
"x6",
},
},
{Count: 1, Values: []string{"x1"}},
{Count: 1, Values: []string{"x3"}},
{Count: 1, Values: []string{"x5"}},
{Count: 1, Values: []string{"x2"}},
{Count: 2, Values: []string{"x6"}},
},
},
}},
Expand All @@ -688,18 +681,11 @@ func TestFindTopologyAssignments(t *testing.T) {
wantAssignment: &kueue.TopologyAssignment{
Levels: defaultOneLevel,
Domains: []kueue.TopologyDomainAssignment{
{
Count: 4,
Values: []string{
"x3",
},
},
{
Count: 2,
Values: []string{
"x6",
},
},
{Count: 1, Values: []string{"x1"}},
{Count: 1, Values: []string{"x3"}},
{Count: 1, Values: []string{"x5"}},
{Count: 1, Values: []string{"x2"}},
{Count: 2, Values: []string{"x6"}},
},
},
}},
Expand Down
2 changes: 1 addition & 1 deletion pkg/features/kube_features.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,7 +258,7 @@ var defaultVersionedFeatureGates = map[featuregate.Feature]featuregate.Versioned
},
TASProfileMixed: {
{Version: version.MustParse("0.10"), Default: false, PreRelease: featuregate.Alpha},
{Version: version.MustParse("0.11"), Default: false, PreRelease: featuregate.Deprecated},
{Version: version.MustParse("0.15"), Default: true, PreRelease: featuregate.Beta},
},
HierarchicalCohorts: {
{Version: version.MustParse("0.11"), Default: true, PreRelease: featuregate.Beta},
Expand Down