-
Notifications
You must be signed in to change notification settings - Fork 2
feat: Add support for user agents and wrapper names. #246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 7 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
974f6ae
feat: Add support for user agents and wrapper names.
kinyoklion 0f5b8a6
Extend go API with user-agent/wrapper-name
kinyoklion 09eef7a
Empty user agents.
kinyoklion 6a814a1
Add user agent products.
kinyoklion 8ee2759
Add products for packages.
kinyoklion 021dd12
Extra blank ingore.
kinyoklion e72362e
Add tests for JS package.
kinyoklion aae7fe6
Rename search function.
kinyoklion 03496ef
Deterministic order.
kinyoklion File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,4 @@ | ||
| .idea | ||
| tool/test.sqlite3 | ||
| metadata.sqlite3.new | ||
| tool/ingest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| { | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Added this information to js-core and then did a crawl for just these products. |
||
| "akamai-base": { | ||
| "userAgents": [ | ||
| "AkamaiEdgeSDK" | ||
| ] | ||
| }, | ||
| "akamai-edgekv": { | ||
| "userAgents": [ | ||
| "AkamaiEdgeSDK" | ||
| ] | ||
| }, | ||
| "cloudflare": { | ||
| "userAgents": [ | ||
| "CloudflareEdgeSDK" | ||
| ] | ||
| }, | ||
| "fastly": { | ||
| "userAgents": [ | ||
| "FastlyEdgeSDK" | ||
| ] | ||
| }, | ||
| "node-server": { | ||
| "userAgents": [ | ||
| "NodeJSClient" | ||
| ] | ||
| }, | ||
| "react-native": { | ||
| "userAgents": [ | ||
| "ReactNativeClient" | ||
| ], | ||
| "wrapperNames": [ | ||
| "react-native-client" | ||
| ] | ||
| }, | ||
| "vercel": { | ||
| "userAgents": [ | ||
| "VercelEdgeSDK" | ||
| ] | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| { | ||
| "akamai-base": { | ||
| "userAgents": [ | ||
| "AkamaiEdgeSDK" | ||
| ] | ||
| }, | ||
| "akamai-edgekv": { | ||
| "userAgents": [ | ||
| "AkamaiEdgeSDK" | ||
| ] | ||
| }, | ||
| "cloudflare": { | ||
| "userAgents": [ | ||
| "CloudflareEdgeSDK" | ||
| ] | ||
| }, | ||
| "fastly": { | ||
| "userAgents": [ | ||
| "FastlyEdgeSDK" | ||
| ] | ||
| }, | ||
| "node-server": { | ||
| "userAgents": [ | ||
| "NodeJSClient" | ||
| ] | ||
| }, | ||
| "react-native": { | ||
| "userAgents": [ | ||
| "ReactNativeClient" | ||
| ], | ||
| "wrapperNames": [ | ||
| "react-native-client" | ||
| ] | ||
| }, | ||
| "vercel": { | ||
| "userAgents": [ | ||
| "VercelEdgeSDK" | ||
| ] | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| { | ||
| "akamai-base": { | ||
| "userAgents": [ | ||
| "AkamaiEdgeSDK" | ||
| ] | ||
| }, | ||
| "akamai-edgekv": { | ||
| "userAgents": [ | ||
| "AkamaiEdgeSDK" | ||
| ] | ||
| }, | ||
| "cloudflare": { | ||
| "userAgents": [ | ||
| "CloudflareEdgeSDK" | ||
| ] | ||
| }, | ||
| "fastly": { | ||
| "userAgents": [ | ||
| "FastlyEdgeSDK" | ||
| ] | ||
| }, | ||
| "node-server": { | ||
| "userAgents": [ | ||
| "NodeJSClient" | ||
| ] | ||
| }, | ||
| "react-native": { | ||
| "userAgents": [ | ||
| "ReactNativeClient" | ||
| ], | ||
| "wrapperNames": [ | ||
| "react-native-client" | ||
| ] | ||
| }, | ||
| "vercel": { | ||
| "userAgents": [ | ||
| "VercelEdgeSDK" | ||
| ] | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| { | ||
| "$schema": "https://json-schema.org/draft/2020-12/schema", | ||
| "$id": "https://launchdarkly.com/sdk-meta/user_agents.json", | ||
| "title": "SDK User Agents", | ||
| "description": "List of SDK User Agents and Wrappers", | ||
| "type": "object", | ||
| "$defs": { | ||
| "SDKUserAgentMap": { | ||
| "type": "object", | ||
| "description": "Map of user agents for an SDK", | ||
| "properties": { | ||
| "userAgents": { | ||
| "$ref": "#/$defs/AgentValue" | ||
| }, | ||
| "wrapperNames": { | ||
| "$ref": "#/$defs/AgentValue" | ||
| } | ||
| }, | ||
| "minProperties": 1, | ||
| "additionalProperties": false | ||
| }, | ||
| "AgentValue": { | ||
| "type": "array", | ||
| "description": "An array of header values, each matching a pattern.", | ||
| "minItems": 1, | ||
| "items": { | ||
| "type": "string", | ||
| "pattern": "^[A-Za-z-]*$" | ||
| } | ||
| } | ||
| }, | ||
| "patternProperties": { | ||
| "^[a-z-]+$": { | ||
| "$ref": "#/$defs/SDKUserAgentMap" | ||
| } | ||
| }, | ||
| "additionalProperties": false | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a somewhat strange pattern, but it is what was done in this package already. Probably could just be top level functions.