Fix Java build warnings #717
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses Java build warnings by replacing raw types with parameterized types and updating deprecated API usage. The changes eliminate the need for @SuppressWarnings annotations in the modified files.
- Replaced raw
Vectortypes with parameterizedVector<?, ?>wildcards inFeatureTable.java - Updated all
FsstEncoder.decode()calls inStringDecoder.javato use the non-deprecated 4-parameter version - Added
decompressedLengthcalculation as the sum of length values where needed
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| java/mlt-core/src/main/java/org/maplibre/mlt/vector/FeatureTable.java | Replaced raw Vector types with Vector<?, ?> wildcards to eliminate rawtypes warnings |
| java/mlt-core/src/main/java/org/maplibre/mlt/decoder/StringDecoder.java | Updated three deprecated FsstEncoder.decode() calls to use the non-deprecated 4-parameter version with explicit decompressed length |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
HarelM
approved these changes
Nov 22, 2025
Collaborator
HarelM
left a comment
HarelM
left a comment
There was a problem hiding this comment.
Is it possible to add "treat warnings as errors" to avoid future additions to warnings?
Member
Author
|
@HarelM I think that is already the case, but these warnings where manually suppressed. |
TimSylvester
approved these changes
Nov 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #552