Skip to content

Fix Java build warnings #717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 24, 2025
+19 −21
Merged

Fix Java build warnings #717

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a7bf867
Fix Java build warnings
louwers Nov 22, 2025
077efa0
run spotlessApply
louwers Nov 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 12 additions & 7 deletions java/mlt-core/src/main/java/org/maplibre/mlt/decoder/StringDecoder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,12 +87,13 @@ public static HashMap<String, List<String>> resolve(

List<String> dictionary = null;
if (symbolLengthStream != null && symbolTableStream != null && dictionaryLengthStream != null) {
@SuppressWarnings("deprecation")
var decompressedLength = dictionaryLengthStream.stream().mapToInt(i -> i).sum();
var utf8Values =
FsstEncoder.decode(
symbolTableStream,
symbolLengthStream.stream().mapToInt(i -> i).toArray(),
dictionaryStream);
dictionaryStream,
decompressedLength);
dictionary = decodeDictionary(dictionaryLengthStream, utf8Values);
} else if (dictionaryLengthStream != null) {
dictionary = decodeDictionary(dictionaryLengthStream, dictionaryStream);
Expand Down Expand Up @@ -208,11 +209,13 @@ public static Triple<Integer, BitSet, List<String>> decode(
}

if (symbolTableStream != null && symbolLengthStream != null && dictionaryLengthStream != null) {
var decompressedLength = dictionaryLengthStream.stream().mapToInt(i -> i).sum();
var utf8Values =
FsstEncoder.decode(
symbolTableStream,
symbolLengthStream.stream().mapToInt(i -> i).toArray(),
dictionaryStream);
dictionaryStream,
decompressedLength);
return Triple.of(
numValues,
presentStream,
Expand Down Expand Up @@ -316,12 +319,14 @@ public static List<String> decodeFsstDictionaryEncodedStringColumn(byte[] data,
compressedCorpusOffset.get(),
compressedCorpusOffset.get() + compressedCorpusMetadata.byteLength());

@SuppressWarnings("deprecation")
var length = IntegerDecoder.decodeIntStream(data, lengthOffset, lengthMetadata, false);
var decompressedLength = length.stream().mapToInt(i -> i).sum();
var values =
FsstEncoder.decode(
symbols, symbolLength.stream().mapToInt(i -> i).toArray(), compressedCorpus);

var length = IntegerDecoder.decodeIntStream(data, lengthOffset, lengthMetadata, false);
symbols,
symbolLength.stream().mapToInt(i -> i).toArray(),
compressedCorpus,
decompressedLength);
var decodedData = IntegerDecoder.decodeIntStream(data, dataOffset, dataMetadata, false);

var decodedDictionary = new ArrayList<String>();
Expand Down
21 changes: 7 additions & 14 deletions java/mlt-core/src/main/java/org/maplibre/mlt/vector/FeatureTable.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,26 +14,21 @@
public class FeatureTable implements Iterable<Feature> {
private final String name;

@SuppressWarnings("rawtypes")
private final Vector idColumn;
private final Vector<?, ?> idColumn;

private final GeometryVector geometryColumn;

@SuppressWarnings("rawtypes")
private final Vector[] propertyColumns;
private final Vector<?, ?>[] propertyColumns;

public FeatureTable(
String name,
GeometryVector geometryVector,
@SuppressWarnings("rawtypes") Vector[] properties) {
public FeatureTable(String name, GeometryVector geometryVector, Vector<?, ?>[] properties) {
this(name, null, geometryVector, properties);
}

public FeatureTable(
String name,
@SuppressWarnings("rawtypes") Vector idColumn,
Vector<?, ?> idColumn,
GeometryVector geometryVector,
@SuppressWarnings("rawtypes") Vector[] properties) {
Vector<?, ?>[] properties) {
this.name = name;
this.idColumn = idColumn;
this.geometryColumn = geometryVector;
Expand Down Expand Up @@ -87,17 +82,15 @@ public String getName() {
return name;
}

@SuppressWarnings("rawtypes")
public Vector getIdColumn() {
public Vector<?, ?> getIdColumn() {
return idColumn;
}

public GeometryVector getGeometryColumn() {
return geometryColumn;
}

@SuppressWarnings("rawtypes")
public Vector[] getPropertyColumns() {
public Vector<?, ?>[] getPropertyColumns() {
return propertyColumns;
}
}