-
Notifications
You must be signed in to change notification settings - Fork 511
Add ::details-content example.
#2874
Conversation
|
Linter doesn't seem aware of this new pseudo element. PR to update stylelint stylelint/stylelint#8174 |
chrisdavidmills
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @lukewarlow, thanks for submitting the new example; looks good to me.
I'll approve this, but I'm assuming we shouldn't (or can't) merge it until the new stylelint package is picked up by our code?
|
@chrisdavidmills we can either wait or I can update the stylelint config to ignore the error for this specific pseudo element. |
@lukewarlow I'm happy with either approach. Take your pick. |
|
maybe now it's better to add it to mdn/content |
|
Stylelint has been updated so I'm assuming this is ready to go with a rebase (I'm not able to do that till tomorrow but someone else can)? Apologies I let this drop off my radar. |
Sorry, this is the context -> https://github.com/orgs/mdn/discussions/782#discussion-7920265 tl;dr we're consolidating infrastructure so we can maintain the interactive examples in-page with the rest of the content. See https://github.com/mdn/content/pull/38356/files. If you want to wait for that ( edit: and the timeline for "wait for that ( |
|
Ah I'll move it over there once that's done then! |
|
This is now merged if you'd like to have a go at adding the example in content: |
Description
Adds an example for the new
::details-contentpseudo element.Motivation
To showcase this on the MDN page.
Additional details
https://drafts.csswg.org/css-pseudo/#details-content-pseudo
Related issues and pull requests