Skip to content
This repository was archived by the owner on Oct 17, 2025. It is now read-only.

Conversation

@lukewarlow
Copy link
Contributor

Description

Adds an example for the new ::details-content pseudo element.

Motivation

To showcase this on the MDN page.

Additional details

https://drafts.csswg.org/css-pseudo/#details-content-pseudo

Related issues and pull requests

@lukewarlow lukewarlow requested a review from a team as a code owner December 6, 2024 11:54
@lukewarlow lukewarlow requested review from chrisdavidmills and removed request for a team December 6, 2024 11:54
@lukewarlow
Copy link
Contributor Author

lukewarlow commented Dec 6, 2024

Linter doesn't seem aware of this new pseudo element. PR to update stylelint stylelint/stylelint#8174

Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @lukewarlow, thanks for submitting the new example; looks good to me.

I'll approve this, but I'm assuming we shouldn't (or can't) merge it until the new stylelint package is picked up by our code?

@lukewarlow
Copy link
Contributor Author

@chrisdavidmills we can either wait or I can update the stylelint config to ignore the error for this specific pseudo element.

@chrisdavidmills
Copy link
Contributor

@chrisdavidmills we can either wait or I can update the stylelint config to ignore the error for this specific pseudo element.

@lukewarlow I'm happy with either approach. Take your pick.

@github-actions github-actions bot added the idle Issues and pull requests with no activity for three months. label Jan 16, 2025
@skyclouds2001
Copy link
Contributor

maybe now it's better to add it to mdn/content

@lukewarlow
Copy link
Contributor Author

Stylelint has been updated so I'm assuming this is ready to go with a rebase (I'm not able to do that till tomorrow but someone else can)? Apologies I let this drop off my radar.

@bsmth
Copy link
Member

bsmth commented Mar 2, 2025

Stylelint has been updated so I'm assuming this is ready to go with a rebase (I'm not able to do that till tomorrow but someone else can)? Apologies I let this drop off my radar.

Sorry, this is the context -> https://github.com/orgs/mdn/discussions/782#discussion-7920265

tl;dr we're consolidating infrastructure so we can maintain the interactive examples in-page with the rest of the content. See https://github.com/mdn/content/pull/38356/files. If you want to wait for that (#38356) PR to land, then we'll accept the changes in the new format in https://github.com/mdn/content/blob/main/files/en-us/web/css/_doublecolon_details-content/index.md?plain=1

edit: and the timeline for "wait for that (#38356) PR to land" means tomorrow if all goes to plan

@lukewarlow
Copy link
Contributor Author

Ah I'll move it over there once that's done then!

@github-actions github-actions bot removed the idle Issues and pull requests with no activity for three months. label Mar 3, 2025
@bsmth
Copy link
Member

bsmth commented Mar 3, 2025

This is now merged if you'd like to have a go at adding the example in content:

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants