Move datatype_conversion.hpp from public include to internal src directory #684
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: chhwang <[email protected]>
Co-authored-by: chhwang <[email protected]>
Copilot
AI
changed the title
[WIP] Move mscclpp file to apps/nccl/src/ directory
Move datatype_conversion.hpp from public include to internal src directory
Nov 15, 2025
Copilot finished work on behalf of
chhwang
November 15, 2025 20:04
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses review feedback on #671 to relocate
datatype_conversion.hppfrom the public API headers to the internal implementation directory.Changes
apps/nccl/include/mscclpp/datatype_conversion.hpp→apps/nccl/src/datatype_conversion.hpp#include <mscclpp/datatype_conversion.hpp>to#include "datatype_conversion.hpp"in:nccl.cuallreduce.cuallgather.cubroadcast.cuThis prevents the header from being installed as part of the public API and resolves installation issues with the CMake file glob patterns.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.