Skip to content

Conversation

@chris1642
Copy link
Contributor

@chris1642 chris1642 commented Nov 30, 2025

Brings 'Object Display Name' to Visual Filters, Page Filters, and Report Filters.

(this is the remaining 3 categories that allow you to rename a report object in the same way as Visual Objects - where the display name is already captured).

@m-kovalsky This follows the same pattern and logic currently used to pull in the object display name for the Visual Objects.

Brings 'Object Display Name' to Visual Filters, Page Filters, and Report Filters 

(this is the remaining 3 categories that allow you to rename a visual object, in addition to Visual Objects)
@chris1642 chris1642 changed the title Adds Object Display Name to Visual, Page, and Report Filter categories Adds Object Display Name to Visual Filter, Page Filter, and Report Filter categories Nov 30, 2025
Copy link
Collaborator

@m-kovalsky m-kovalsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks. the Object Display Name should default to the Object Name if the Object Default Name is None.

flt.get("displayName", object_name)

@chris1642
Copy link
Contributor Author

@m-kovalsky for clarity, do you want that change for the current Visual Objects as well? In the current list_visual_objects, it doesn't fallback to Object Name if there is no alternate display name.

I will error on the side of consistency and apply to all 4 unless said otherwise :)

@m-kovalsky
Copy link
Collaborator

@m-kovalsky for clarity, do you want that change for the current Visual Objects as well? In the current list_visual_objects, it doesn't fallback to Object Name if there is no alternate display name.

I will error on the side of consistency and apply to all 4 unless said otherwise :)

Yes, good call. Thank you!

@chris1642
Copy link
Contributor Author

@m-kovalsky Fallback added for all 4 categories!

@chris1642 chris1642 requested a review from m-kovalsky December 15, 2025 18:25
Copy link
Collaborator

@m-kovalsky m-kovalsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@m-kovalsky m-kovalsky merged commit 9917136 into microsoft:main Dec 16, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants