Skip to content

fix: Fix insights query date range calculation in backend #21409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Nov 3, 2025
Merged

fix: Fix insights query date range calculation in backend #21409

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c5d5fc0
test: refactor insights cte query unit tests
ireneea Oct 30, 2025
ca7caca
feat: fixed query calculation
ireneea Oct 30, 2025
a8dcba5
test: Added unit tests for the InsightsService
ireneea Oct 30, 2025
2036620
test: Add comprehensive unit tests for insights summary calculations
ireneea Oct 30, 2025
1019dad
test: Add unit test for complete insights summary with all summary data
ireneea Oct 30, 2025
47fe168
test: Simplified getInsightsSummary integration tests
ireneea Oct 31, 2025
d961b94
text: Fix default date test for insights controller
ireneea Oct 31, 2025
3fbaada
Merge branch 'master' into pay-4052-insights-query-date-range-calcula…
ireneea Nov 3, 2025
b9d3099
Merge branch 'master' into pay-4052-insights-query-date-range-calcula…
ireneea Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions packages/cli/src/modules/insights/__tests__/insights.controller.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ afterAll(async () => {
describe('InsightsController', () => {
const insightsByPeriodRepository = mockInstance(InsightsByPeriodRepository);
let controller: InsightsController;
const sevenDaysAgo = DateTime.now().minus({ days: 7 }).toJSDate();
const sixDaysAgo = DateTime.now().minus({ days: 6 }).toJSDate();
const today = DateTime.now().toJSDate();
const licenseState = mock<LicenseState>();

Expand Down Expand Up @@ -62,7 +62,7 @@ describe('InsightsController', () => {

const callArgs =
insightsByPeriodRepository.getPreviousAndCurrentPeriodTypeAggregates.mock.calls[0][0];
expectDatesClose(callArgs.startDate, sevenDaysAgo);
expectDatesClose(callArgs.startDate, sixDaysAgo);
expectDatesClose(callArgs.endDate, today);

expect(response).toEqual({
Expand Down Expand Up @@ -102,7 +102,7 @@ describe('InsightsController', () => {

const callArgs =
insightsByPeriodRepository.getPreviousAndCurrentPeriodTypeAggregates.mock.calls[0][0];
expectDatesClose(callArgs.startDate, sevenDaysAgo);
expectDatesClose(callArgs.startDate, sixDaysAgo);
expectDatesClose(callArgs.endDate, today);

expect(response).toEqual({
Expand Down Expand Up @@ -146,7 +146,7 @@ describe('InsightsController', () => {

const callArgs =
insightsByPeriodRepository.getPreviousAndCurrentPeriodTypeAggregates.mock.calls[0][0];
expectDatesClose(callArgs.startDate, sevenDaysAgo);
expectDatesClose(callArgs.startDate, sixDaysAgo);
expectDatesClose(callArgs.endDate, today);

expect(response).toEqual({
Expand Down Expand Up @@ -399,7 +399,7 @@ describe('InsightsController', () => {
});

const callArgs = insightsByPeriodRepository.getInsightsByWorkflow.mock.calls[0][0];
expectDatesClose(callArgs.startDate, sevenDaysAgo);
expectDatesClose(callArgs.startDate, sixDaysAgo);
expectDatesClose(callArgs.endDate, today);

expect(response).toEqual({ count: 0, data: [] });
Expand Down Expand Up @@ -433,7 +433,7 @@ describe('InsightsController', () => {
});

const callArgs = insightsByPeriodRepository.getInsightsByWorkflow.mock.calls[0][0];
expectDatesClose(callArgs.startDate, sevenDaysAgo);
expectDatesClose(callArgs.startDate, sixDaysAgo);
expectDatesClose(callArgs.endDate, today);

expect(response).toEqual({ count: 3, data: mockRows });
Expand Down Expand Up @@ -671,7 +671,7 @@ describe('InsightsController', () => {
});

const callArgs = insightsByPeriodRepository.getInsightsByTime.mock.calls[0][0];
expectDatesClose(callArgs.startDate, sevenDaysAgo);
expectDatesClose(callArgs.startDate, sixDaysAgo);
expectDatesClose(callArgs.endDate, today);

expect(response).toEqual([]);
Expand All @@ -694,7 +694,7 @@ describe('InsightsController', () => {
});

const callArgs = insightsByPeriodRepository.getInsightsByTime.mock.calls[0][0];
expectDatesClose(callArgs.startDate, sevenDaysAgo);
expectDatesClose(callArgs.startDate, sixDaysAgo);
expectDatesClose(callArgs.endDate, today);

expect(response).toEqual(expectedResponse);
Expand Down Expand Up @@ -740,7 +740,7 @@ describe('InsightsController', () => {
});

const callArgs = insightsByPeriodRepository.getInsightsByTime.mock.calls[0][0];
expectDatesClose(callArgs.startDate, sevenDaysAgo);
expectDatesClose(callArgs.startDate, sixDaysAgo);
expectDatesClose(callArgs.endDate, today);

expect(response).toEqual(expectedResponse);
Expand Down Expand Up @@ -887,7 +887,7 @@ describe('InsightsController', () => {
});

const callArgs = insightsByPeriodRepository.getInsightsByTime.mock.calls[0][0];
expectDatesClose(callArgs.startDate, sevenDaysAgo);
expectDatesClose(callArgs.startDate, sixDaysAgo);
expectDatesClose(callArgs.endDate, today);

expect(response).toEqual(expectedResponse);
Expand All @@ -912,7 +912,7 @@ describe('InsightsController', () => {
});

const callArgs = insightsByPeriodRepository.getInsightsByTime.mock.calls[0][0];
expectDatesClose(callArgs.startDate, sevenDaysAgo);
expectDatesClose(callArgs.startDate, sixDaysAgo);
expectDatesClose(callArgs.endDate, today);

expect(response).toEqual(expectedResponse);
Expand Down
Loading
Loading