Skip to content

Conversation

@rogercoll
Copy link
Contributor

Fixes #1661

Changes

Please provide a brief description of the changes here.

Important

Pull requests acceptance are subject to the triage process as described in Issue and PR Triage Management.
PRs that do not follow the guidance above, may be automatically rejected and closed.

Merge requirement checklist

  • CONTRIBUTING.md guidelines followed.
  • Change log entry added, according to the guidelines in When to add a changelog entry.
    • If your PR does not need a change log, start the PR title with [chore]
  • Links to the prototypes or existing instrumentations (when adding or changing conventions)

@github-actions
Copy link

This PR contains changes to area(s) that do not have an active SIG/project and will be auto-closed:

  • linux

Such changes may be rejected or put on hold until a new SIG/project is established.

Please refer to the Semantic Convention Areas
document to see the current active SIGs and also to learn how to kick start a new one.

@rogercoll
Copy link
Contributor Author

Reopening because of this PR changes removing any metric/attribute in the Linux area

@rogercoll rogercoll reopened this Oct 27, 2025
@github-actions
Copy link

This PR contains changes to area(s) that do not have an active SIG/project and will be auto-closed:

  • linux

Such changes may be rejected or put on hold until a new SIG/project is established.

Please refer to the Semantic Convention Areas
document to see the current active SIGs and also to learn how to kick start a new one.

@github-actions github-actions bot closed this Oct 27, 2025
@ChrsMark ChrsMark reopened this Oct 27, 2025
@github-actions
Copy link

This PR contains changes to area(s) that do not have an active SIG/project and will be auto-closed:

  • linux

Such changes may be rejected or put on hold until a new SIG/project is established.

Please refer to the Semantic Convention Areas
document to see the current active SIGs and also to learn how to kick start a new one.

@github-actions github-actions bot closed this Oct 27, 2025
@ChrsMark ChrsMark reopened this Oct 27, 2025
@lmolkova lmolkova moved this from Untriaged to Needs More Approval in Semantic Conventions Triage Oct 27, 2025
- id: metric.system.memory.linux.slab.usage
type: metric
metric_name: system.linux.memory.slab.usage
metric_name: system.memory.linux.slab.usage
Copy link
Member

@lmolkova lmolkova Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think https://github.com/open-telemetry/semantic-conventions/blob/main/docs/non-normative/groups/system/design-philosophy.md#operating-system-in-names talks about root namespace, is there a need or benefit in renaming system.linux.memory.slab.usage to system.memory.linux.slab.usage ?

In the new version, linux looks like a property of memory and separates actual slab.usage property. In the old version it feels in the right place - it's a property of a system.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might need to rephrase it, but I think instead of "root namespace" what we meant is {area}. The way we think a user interacts with system metrics is by first looking into the area of interest (e.g. memory consumption alert) and then (if needed), looking to the OS more fine-grained metrics for that area.

If we just apply the rule to root namespaces, we could end up having a mix of unordered metrics like memory.linux.* and system.linux.memory.*.

cc @braydonk

Copy link
Member

@lmolkova lmolkova Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not going to block on this, but I'm still raising concern. It seems random where OS name is included and it affects name readability

@lmolkova lmolkova enabled auto-merge October 30, 2025 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Needs More Approval

Development

Successfully merging this pull request may close these issues.

Rename linux.memory.* metrics and attributes to memory.linux.*

6 participants