-
Notifications
You must be signed in to change notification settings - Fork 278
Rename *.linux.memory to *.memory.linux #2984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
This PR contains changes to area(s) that do not have an active SIG/project and will be auto-closed:
Such changes may be rejected or put on hold until a new SIG/project is established. Please refer to the Semantic Convention Areas |
|
Reopening because of this PR changes removing any metric/attribute in the Linux area |
|
This PR contains changes to area(s) that do not have an active SIG/project and will be auto-closed:
Such changes may be rejected or put on hold until a new SIG/project is established. Please refer to the Semantic Convention Areas |
|
This PR contains changes to area(s) that do not have an active SIG/project and will be auto-closed:
Such changes may be rejected or put on hold until a new SIG/project is established. Please refer to the Semantic Convention Areas |
| - id: metric.system.memory.linux.slab.usage | ||
| type: metric | ||
| metric_name: system.linux.memory.slab.usage | ||
| metric_name: system.memory.linux.slab.usage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think https://github.com/open-telemetry/semantic-conventions/blob/main/docs/non-normative/groups/system/design-philosophy.md#operating-system-in-names talks about root namespace, is there a need or benefit in renaming system.linux.memory.slab.usage to system.memory.linux.slab.usage ?
In the new version, linux looks like a property of memory and separates actual slab.usage property. In the old version it feels in the right place - it's a property of a system.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might need to rephrase it, but I think instead of "root namespace" what we meant is {area}. The way we think a user interacts with system metrics is by first looking into the area of interest (e.g. memory consumption alert) and then (if needed), looking to the OS more fine-grained metrics for that area.
If we just apply the rule to root namespaces, we could end up having a mix of unordered metrics like memory.linux.* and system.linux.memory.*.
cc @braydonk
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not going to block on this, but I'm still raising concern. It seems random where OS name is included and it affects name readability
Fixes #1661
Changes
Please provide a brief description of the changes here.
Important
Pull requests acceptance are subject to the triage process as described in Issue and PR Triage Management.
PRs that do not follow the guidance above, may be automatically rejected and closed.
Merge requirement checklist
[chore]