Rename *.linux.memory to *.memory.linux #2984
+111
−32
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| # Use this changelog template to create an entry for release notes. | ||
| # | ||
| # If your change doesn't affect end users you should instead start | ||
| # your pull request title with [chore] or use the "Skip Changelog" label. | ||
|
|
||
| # One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix' | ||
| change_type: breaking | ||
|
|
||
| # The name of the area of concern in the attributes-registry, (e.g. http, cloud, db) | ||
| component: system, linux | ||
|
|
||
| # A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`). | ||
| note: Rename `*.linux.memory` metrics and attributes to `*.memory.linux` | ||
|
|
||
| # Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists. | ||
| # The values here must be integers. | ||
| issues: [1661] | ||
|
|
||
| # (Optional) One or more lines of additional information to render under the primary note. | ||
| # These lines will be padded with 2 spaces and then inserted directly into the document. | ||
| # Use pipe (|) for multiline entries. | ||
| subtext: | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -65,7 +65,6 @@ body: | |
| - area:ios | ||
| - area:jvm | ||
| - area:k8s | ||
| - area:log | ||
| - area:mainframe | ||
| - area:messaging | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -57,7 +57,6 @@ body: | |
| - area:ios | ||
| - area:jvm | ||
| - area:k8s | ||
| - area:log | ||
| - area:mainframe | ||
| - area:messaging | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -68,7 +68,6 @@ body: | |
| - area:ios | ||
| - area:jvm | ||
| - area:k8s | ||
| - area:log | ||
| - area:mainframe | ||
| - area:messaging | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -524,10 +524,10 @@ groups: | |
| entity_associations: | ||
| - host | ||
|
|
||
| # system.memory.linux.* metrics | ||
| - id: metric.system.memory.linux.available | ||
| type: metric | ||
| metric_name: system.memory.linux.available | ||
| annotations: | ||
| code_generation: | ||
| metric_value_type: int | ||
|
|
@@ -545,21 +545,21 @@ groups: | |
| entity_associations: | ||
| - host | ||
|
|
||
| - id: metric.system.memory.linux.slab.usage | ||
| type: metric | ||
| metric_name: system.memory.linux.slab.usage | ||
|
There was a problem hiding this comment. I think https://github.com/open-telemetry/semantic-conventions/blob/main/docs/non-normative/groups/system/design-philosophy.md#operating-system-in-names talks about root namespace, is there a need or benefit in renaming In the new version, linux looks like a property of There was a problem hiding this comment. We might need to rephrase it, but I think instead of "root namespace" what we meant is {area}. The way we think a user interacts with system metrics is by first looking into the area of interest (e.g. memory consumption alert) and then (if needed), looking to the OS more fine-grained metrics for that area. If we just apply the rule to root namespaces, we could end up having a mix of unordered metrics like cc @braydonk There was a problem hiding this comment. I'm not going to block on this, but I'm still raising concern. It seems random where OS name is included and it affects name readability There was a problem hiding this comment. Semconv SIG discussion: could you please update the guidance based on this discussion? thanks! |
||
| annotations: | ||
| code_generation: | ||
| metric_value_type: int | ||
| stability: development | ||
| brief: "Reports the memory used by the Linux kernel for managing caches of frequently used objects." | ||
| note: | | ||
| The sum over the `reclaimable` and `unreclaimable` state values in `memory.linux.slab.usage` SHOULD be equal to the total slab memory available on the system. | ||
| Note that the total slab memory is not constant and may vary over time. | ||
| See also the [Slab allocator](https://blogs.oracle.com/linux/post/understanding-linux-kernel-memory-statistics) and `Slab` in [/proc/meminfo](https://man7.org/linux/man-pages/man5/proc.5.html). | ||
| instrument: updowncounter | ||
| unit: "By" | ||
| attributes: | ||
| - ref: system.memory.linux.slab.state | ||
| entity_associations: | ||
| - host | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.