Skip to content

Conversation

@epugh
Copy link
Collaborator

@epugh epugh commented Nov 11, 2025

Description

For JudgmentComboBox it filters to just COMPLETED judgments, but preserves the list all Judgments page.

Issues Resolved

Fixes opensearch-project/search-relevance#266

Check List

  • [ x] New functionality includes testing.
    • [ x] All tests pass, including unit test, integration test
  • New functionality has been documented.
  • [ x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds optional status filtering for judgment list queries, allowing the JudgmentsComboBox component to fetch only COMPLETED judgments while preserving the existing behavior for the judgment listing page.

Key Changes:

  • Added query parameter validation for optional status field in the Judgments GET endpoint
  • Modified backend routing to forward the status query parameter to the backend API
  • Updated JudgmentsComboBox to request only COMPLETED judgments

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
server/routes/search_relevance_route_service.ts Added schema validation for optional status query parameter and logic to append it to backend URL
public/components/judgment/__tests__/use_judgment_list.test.ts Added comment verifying that existing hook continues to request all judgments without status filter
public/components/experiment/configuration/form/judgments_combo_box.tsx Modified to pass status: 'COMPLETED' query parameter when fetching judgments
public/components/experiment/configuration/form/__tests__/judgments_combo_box.test.tsx Added new test file to verify that combo box requests only COMPLETED judgments

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

[BUG] Incomplete judgment ratings groups are available for selection in create experiment workflow

1 participant