generated from amazon-archives/__template_Apache-2.0
-
Notifications
You must be signed in to change notification settings - Fork 63
Add optional status=COMPLETED parameter for filtering judgments. #674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
epugh
wants to merge
4
commits into
opensearch-project:main
Choose a base branch
from
epugh:list_only_COMPLETED_judgments_in_dropdown
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
b7ed669
First pass of adding optional status=COMPLETED parameter for filterin…
epugh 54a8cec
Get the judgment specific logic out and have more generic processing.
epugh 9b98275
Update server/routes/search_relevance_route_service.ts
epugh b089392
Track change
epugh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
51 changes: 51 additions & 0 deletions
51
public/components/experiment/configuration/form/__tests__/judgments_combo_box.test.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| /* | ||
| * Copyright OpenSearch Contributors | ||
| * SPDX-License-Identifier: Apache-2.0 | ||
| */ | ||
|
|
||
| import React from 'react'; | ||
| import { render, screen, waitFor } from '@testing-library/react'; | ||
| import { JudgmentsComboBox } from '../judgments_combo_box'; | ||
| import { ServiceEndpoints } from '../../../../../../common'; | ||
|
|
||
| const mockHttp = { | ||
| get: jest.fn(), | ||
| }; | ||
|
|
||
| describe('JudgmentsComboBox', () => { | ||
| beforeEach(() => { | ||
| jest.clearAllMocks(); | ||
| }); | ||
|
|
||
| it('requests only COMPLETED judgments and renders options', async () => { | ||
| const mockResponse = { | ||
| hits: { | ||
| hits: [ | ||
| { _source: { id: '1', name: 'Completed A', status: 'COMPLETED' } }, | ||
| { _source: { id: '2', name: 'Completed B', status: 'COMPLETED' } }, | ||
| ], | ||
| }, | ||
| }; | ||
| mockHttp.get.mockResolvedValueOnce(mockResponse); | ||
|
|
||
| render( | ||
| <JudgmentsComboBox | ||
| selectedOptions={[]} | ||
| onChange={() => {}} | ||
| http={mockHttp as any} | ||
| hideLabel | ||
| /> | ||
| ); | ||
|
|
||
| // Verify request used status filter | ||
| await waitFor(() => { | ||
| expect(mockHttp.get).toHaveBeenCalledWith(ServiceEndpoints.Judgments, { query: { status: 'COMPLETED' } }); | ||
| }); | ||
|
|
||
| // Placeholder switches to 'Select judgment list' once loaded | ||
| expect(screen.getByText('Select judgment list')).toBeInTheDocument(); | ||
|
|
||
| // Ensure options are mapped (labels visible only when opening combo, but we can rely on mapping without user interaction) | ||
| // For robustness, we check the component rendered without errors and made the expected call. | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.