Fix const in phi3 qwen and minicpm #3072
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wovchena
approved these changes
Nov 25, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses const_cast issues when constructing ov::Tensor objects in visual language processing modules. The changes ensure proper const-correctness when passing data pointers to tensor constructors.
- Added
const_castto pointer arguments when constructingov::Tensorobjects - Reformatted tensor constructor calls for improved readability
- Applied consistent fixes across phi3_vision, qwen2vl, and minicpm modules
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/cpp/src/visual_language/qwen2vl/classes.cpp | Added const_cast for image data pointers and reformatted tensor constructors |
| src/cpp/src/visual_language/phi3_vision/classes.cpp | Added const_cast for token data pointers in placeholder processing |
| src/cpp/src/visual_language/minicpm/classes.cpp | Added const_cast for slice data pointer and reformatted tensor constructor |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
github-actions
bot
added
category: image generation
github-actions
bot
added
category: continuous batching
Merged
via the queue into
openvinotoolkit:master
with commit Nov 26, 2025
65b9356
122 of 124 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix const cast in phi3 qwen and minicpm