async function should return default promise in node:fs/promises #106
+11
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jarred-Sumner
requested changes
Aug 28, 2025
Collaborator
Jarred-Sumner
left a comment
Jarred-Sumner
left a comment
There was a problem hiding this comment.
node:fs/promises shouldn't be special cased here.
Member
Author
If there are no use cases where we want to use JSInternalPromise in Bun's built-ins, sounds good. |
Co-authored-by: Jarred Sumner <[email protected]>
sosukesuzuki
force-pushed
the
fs-promises-should-not-return-internal-promise
branch
from
f51364c to
f987d1e
Compare
Jarred-Sumner
approved these changes
Aug 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes oven-sh/bun#22167
JSC generates bytecode so that async functions defined within built-in JS code return
JSInternalPromiseinstead of the default Promise. This is intentional, but this caused Bun's node:fs/promises exported functions to incorrectly returnJSInternalPromise.This patch changes it to return the appropriate Promise by checking the source URL where the built-in is defined.