Skip to content

async function should return default promise in node:fs/promises #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jarred-Sumner merged 2 commits into from
Aug 28, 2025
Merged

async function should return default promise in node:fs/promises #106

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d521fee
async function should return default promise in node:fs/promises
sosukesuzuki Aug 28, 2025
f987d1e
Update Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp
sosukesuzuki Aug 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -789,8 +789,22 @@ IGNORE_GCC_WARNINGS_END

emitNewGenerator(m_generatorRegister);
bool isInternalPromise = false;
#if USE(BUN_JSC_ADDITIONS)
if (m_isBuiltinFunction) {
const auto isDefaultPromiseForBun = [&]() -> bool {
if (auto* provider = m_scopeNode->source().provider()) {
const String& sourceURL = provider->sourceURL();
if (!sourceURL.isNull() && !sourceURL.isEmpty())
return sourceURL == "node:fs/promises"_s;
}
return false;
};
isInternalPromise = !functionNode->ident().string().startsWith("defaultAsync"_s) && !isDefaultPromiseForBun();
}
#else
if (m_isBuiltinFunction)
isInternalPromise = !functionNode->ident().string().startsWith("defaultAsync"_s);
#endif
emitNewPromise(promiseRegister(), isInternalPromise);
emitPutInternalField(generatorRegister(), static_cast<unsigned>(JSGenerator::Field::Context), promiseRegister());
break;
Expand Down
Loading