fix: always use find_uv
#2690
Open
fix: always use find_uv
#2690
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henryiii
reviewed
Dec 14, 2025
| "install", | ||
| "--upgrade", | ||
| "build[virtualenv]", | ||
| "build[virtualenv, uv]", |
Contributor
There was a problem hiding this comment.
This will install another copy of there is already an external one. I think we try to avoid that everywhere else.
Member
Author
There was a problem hiding this comment.
This will install another copy of there is already an external one.
Yes indeed, hope it's clear enough in the PR description.
I think we try to avoid that everywhere else.
macOS is already doing that.
I'm wondering if the uv extra is not just plain broken when the virtual environment is not activated.
I'll try something else in a following commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to use the
uvextra withoutuvbeing added toPATHhowever it requires to installbuildwith theuvextra. This was already done on macOS.I'm not sure what's the correct way forward given this results in multiple
uvinstallations.towards #2673