Skip to content

fix: always use find_uv #2690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mayeut wants to merge 1 commit into from
Closed

fix: always use find_uv #2690

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions cibuildwheel/platforms/windows.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,7 +329,7 @@ def setup_python(
"pip",
"install",
"--upgrade",
"build[virtualenv]",
"build[virtualenv, uv]",
Copy link
Contributor

@henryiii henryiii Dec 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will install another copy of there is already an external one. I think we try to avoid that everywhere else.

Copy link
Member Author

@mayeut mayeut Dec 14, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will install another copy of there is already an external one.

Yes indeed, hope it's clear enough in the PR description.

I think we try to avoid that everywhere else.

macOS is already doing that.

I'm wondering if the uv extra is not just plain broken when the virtual environment is not activated.
I'll try something else in a following commit.

Copy link
Member Author

@mayeut mayeut Dec 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#2691 opened as an alternative

*constraint_flags(dependency_constraint),
env=env,
)
Expand Down Expand Up @@ -575,7 +575,12 @@ def build(options: Options, tmp_path: Path) -> None:
)
shell(before_test_prepared, env=virtualenv_env)

pip = ["uv", "pip"] if use_uv else ["pip"]
if use_uv:
uv_path = find_uv()
assert uv_path is not None
pip = [str(uv_path), "pip"]
else:
pip = ["pip"]

# install the wheel
call(
Expand Down
6 changes: 5 additions & 1 deletion cibuildwheel/venv.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,11 @@ def virtualenv(
assert python.exists()

if use_uv:
call("uv", "venv", venv_path, "--python", python)
uv_path = find_uv()
if uv_path is None:
msg = "Could not find 'uv' executable."
raise FileNotFoundError(msg)
call(uv_path, "venv", venv_path, "--python", python)
else:
virtualenv_app, virtualenv_version = _ensure_virtualenv(version)
if pip_version is None:
Expand Down
Loading