Align with upstream LangChain4j error handling #2014
Merged
+609
−48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
geoand
force-pushed
the
#2008
branch
2 times, most recently
from
2bd57fb to
2628892
Compare
This is done by introducing support for `@HandleToolExecutionError` and `@HandleToolArgumentError` Closes: #2008
This comment has been minimized.
This comment has been minimized.
Status for workflow
|
cescoffier
changed the title
cescoffier
approved these changes
Dec 11, 2025
Collaborator
cescoffier
left a comment
cescoffier
left a comment
There was a problem hiding this comment.
LGTM
I've 2 small questions:
- how does it work with metrics - I don't believe it should changes anything (a failure is a failure)
- are guardrail call before or after the handler? guardrail can change the result or decide to fail the call.
Collaborator
Author
Nothing should change
Nothing should change WRT guardails |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is done by introducing support for
@HandleToolExecutionErrorand@HandleToolArgumentError