when runnning on modal we get 500 for workspace id params #1759
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
digaobarbosa
requested review from
PawelPeczek-Roboflow,
grzegorz-roboflow,
hansent,
probicheaux and
yeldarby
as code owners
digaobarbosa
changed the title
grzegorz-roboflow
previously approved these changes
Nov 28, 2025
grzegorz-roboflow
approved these changes
Nov 28, 2025
Contributor
⚡️ Codeflash found optimizations for this PR📄 26% (0.26x) speedup for
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using workspace_name + workflow_id for WebRTC initialization, Modal fetches the workflow_specification from the API but doesn't clear workspace_name and workflow_id afterward. T
his causes InferencePipeline.init_with_workflow() to fail on modal
inference/core/interfaces/stream/inference_pipeline.py:596
A request to initialize_webrtc_worker would fail if receiving workspace_name + workflow_id
Type of change
How has this change been tested, please provide a testcase or example of how you tested the change?
locally - but it can be only sure on staging or with modal credentials
Any specific deployment considerations
none
Docs