Skip to content

when runnning on modal we get 500 for workspace id params #1759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 28, 2025
Merged

when runnning on modal we get 500 for workspace id params #1759

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ee152ad
when runnning on modal we would get 500 for workspace id params
digaobarbosa Nov 27, 2025
436e5fc
fixing the fix
digaobarbosa Nov 28, 2025
9fff063
fixing the fix fix
digaobarbosa Nov 28, 2025
c8e8369
fixing the fix fix fix
digaobarbosa Nov 28, 2025
35d966c
Merge branch 'main' into fix-modal-workspace-id-500
grzegorz-roboflow Nov 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions inference/core/interfaces/stream/inference_pipeline.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -596,10 +596,9 @@ def init_with_workflow(
named_workflow_specified = (workspace_name is not None) and (
workflow_id is not None
)
if not (named_workflow_specified != (workflow_specification is not None)):
if not named_workflow_specified and not workflow_specification:
raise ValueError(
"Parameters (`workspace_name`, `workflow_id`) can be used mutually exclusive with "
"`workflow_specification`, but at least one must be set."
"Either (`workspace_name`, `workflow_id`) or `workflow_specification` must be provided."
)
try:
from inference.core.interfaces.stream.model_handlers.workflows import (
Expand Down
1 change: 0 additions & 1 deletion inference/core/interfaces/webrtc_worker/modal.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -423,7 +423,6 @@ def spawn_rtc_peer_connection_modal(
workflow_id=webrtc_request.workflow_configuration.workflow_id,
)
)

tags = {"tag": docker_tag}
if workspace_id:
tags["workspace_id"] = workspace_id
Expand Down