-
Notifications
You must be signed in to change notification settings - Fork 4
add codegen for rekorv2 #168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Ramon Petgrave <[email protected]>
Signed-off-by: Ramon Petgrave <[email protected]>
Signed-off-by: Ramon Petgrave <[email protected]>
Signed-off-by: Ramon Petgrave <[email protected]>
Signed-off-by: Ramon Petgrave <[email protected]>
| --branch="${rekorv2_ref}" \ | ||
| https://github.com/sigstore/rekor-tiles \ | ||
| "${rekorv2_dir}" | ||
| rekorv2_types=(rekor_service) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only the rekor_service has types we are interested in
| "E501", # handled by black, and catches some docstrings we can't autofix | ||
| "ERA001", # false positives | ||
| "D400", # overly opinionated docstrings | ||
| "D205", # 1 blank line required between summary line and description |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would be the first time that the genrated docstrings need to be multiline, but so far the formatters can't autofix.
| "TCH001", # False positive: imports are re-exports, not just for type hints. | ||
| ] | ||
| "src/rekor_types/_internal/*.py" = [ | ||
| "src/rekor_types/_internal/**/*.py" = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
include the new /rekorv2/ subdirectory.
| done | ||
|
|
||
| # RekorV2 | ||
| rekorv2_ref="main" # not yet a non-prelease release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using #main, while there is not an a "latest" release.
Client support for Rekor V2: sigstore-python #289
Fixes #167
Pending #166
Adds codegen for rekorv2
Testing
Steps in the codegen workflow
make dev source env/bin/activate ./codegen/codegen.shgenerated file
Some types, like
apiHttpBodyandProtobufAnymight not be useful, but perhaps in rekor-tiles we can avoid generating them.