Feature/1862 calendar development #2636
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… update styles, and improve date handling
…indicator date handling
…hance negative and indicator date handling; update styles in month-view.scss for better layout control.
…gic, date handling, and visual indicators; remove console logs for cleaner code.
…ontent to header and adjust margins for month indicators. Update select-month and month-view stories for better structure and rendering logic.
…onth selection; improve button styles and interactions for better accessibility and user experience.
…h, improve month selection logic, and update styles for better layout and accessibility.
…ter, enhance year selection logic, and improve button accessibility and styles.
…to validate functionality and ensure proper event handling.
…dd tests for month navigation in SelectDay component.
19 tasks
🦋 Changeset detectedLatest commit: 637254e The changes in this PR will be included in the next version bump. This PR includes changesets to release 37 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
🕸 Website previewYou can view a preview here (commit |
Contributor
🕸 Storybook previewYou can view a preview here (commit |
…m/sl-design-system/components into feature/1862-calendar-development
…add scroll wrapper
…ng as well in the select year view
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements calendar functionality for a date picker component as part of issue #1862. The implementation includes significant upgrades to test infrastructure and styling improvements.
Key changes:
- Upgraded Storybook from v9.1.13 to v10.0.7 and Vitest from v3.2.4 to v4.0.9
- Implemented new calendar components:
SelectDay,SelectMonth,SelectYear, andMonthViewwith comprehensive functionality - Added a new
NewFocusGroupControllerfor improved keyboard navigation in grid layouts - Added support for disabled dates, indicator dates (colored dots), min/max date constraints, and week number display
Reviewed Changes
Copilot reviewed 81 out of 82 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| yarn.lock | Updated dependencies for Storybook v10, Vitest v4, and added new packages like scrollend-polyfill and chai-datetime |
| vitest.setup.ts | Added chai-datetime plugin and updated import paths for Vitest v4 browser utilities |
| vitest.config.ts | Migrated to Vitest v4 with new playwright provider configuration |
| packages/components/shared/src/converters/date-list.ts | New converter for date array attributes |
| packages/components/shared/src/controllers/new-focus-group.ts | New controller for advanced keyboard navigation in grid layouts |
| packages/components/calendar/src/*.ts | Complete implementation of calendar components with accessibility features |
| packages/components/calendar/src/*.spec.ts | Comprehensive test coverage for all calendar components |
| packages/components/calendar/src/*.scss | Styling for calendar components following design system patterns |
| packages/locales/src/nl.* | Dutch translations for calendar labels and announcements |
jpzwarte
approved these changes
Nov 21, 2025
anna-lach
reviewed
Nov 24, 2025
anna-lach
reviewed
Nov 27, 2025
| } | ||
| }; | ||
|
|
||
| export const DisabledDates: Story = { |
Collaborator
There was a problem hiding this comment.
In this story, when I use only arrow right key to move to the next available days, when it moves to the next month it selects (even when I'm not selecting anything) the first day of next month and there when I use arrow right key again it jumps to the next month (which is disabled, so should not be available).
Screen.Recording.2025-11-27.at.15.11.40.mov
Collaborator
Author
|
When you hover over an indicator dot and then move on to the date the tooltip doesn't disappear. Screen.Recording.2025-11-27.at.15.43.27-1.mov |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.