-
Notifications
You must be signed in to change notification settings - Fork 6
Feature/1862 calendar development #2636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Diaan
wants to merge
148
commits into
main
Choose a base branch
from
feature/1862-calendar-development
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 136 commits
Commits
Show all changes
148 commits
Select commit
Hold shift + click to select a range
b6e46ba
Enhance Calendar component with negative and indicator date features,…
Diaan 787a87b
Merge remote-tracking branch 'origin/main' into feature/1862-calendar…
Diaan 288260f
Update Calendar component stories and styles to enhance negative and …
Diaan 46692a8
Refactor Calendar component stories to improve rendering logic and en…
Diaan 06258fd
Remove console logs and simplify conditions in Calendar and MonthView…
Diaan c31f994
Enhance Calendar component stories and styles to improve rendering lo…
Diaan 19b13c7
Refactor styles in select-day.scss for improved layout; add justify-c…
Diaan 62e3589
Refactor SelectMonth component to replace sl-button with button for m…
Diaan 74ee3b9
Merge remote-tracking branch 'origin/main' into feature/1862-calendar…
Diaan cfca76b
Enhance calendar component: add min/max date properties to SelectMont…
Diaan 3538ee1
Refactor SelectYear component: update year property to use dateConver…
Diaan f816c7a
Add unit tests for SelectDay, SelectMonth, and SelectYear components …
Diaan fa34625
Remove unused story files for SelectDay and SelectMonth components; a…
Diaan 7c36c0d
Merge remote-tracking branch 'origin/main' into feature/1862-calendar…
Diaan 951a458
Merge branch 'main' into feature/1862-calendar-development
Diaan 8abdbf0
feat: add inert property to calendar components and improve mode hand…
Diaan 2e966f1
Merge branch 'feature/1862-calendar-development' of https://github.co…
Diaan c217ad2
feat: add selected date property to calendar components and update se…
Diaan 7b6fe98
disable some tests to get the build working
Diaan 7915435
feat: refactor SelectDay component to improve scrolling behavior and …
Diaan eee7d1f
feat: add month display to MonthView and improve SelectDay component …
Diaan 9b65a6c
Merge remote-tracking branch 'origin/main' into feature/1862-calendar…
Diaan 96127dd
feat: add logging for month updates in Calendar and SelectDay components
Diaan 94136af
Merge remote-tracking branch 'origin/main' into feature/1862-calendar…
anna-lach 6214136
fixes the problem with setting month
anna-lach df27ffc
fixed arrow keys navigation in the month view, partially got it worki…
anna-lach 173fe8c
select year keyboard navigation changes
anna-lach f731d36
make it working with min and max in the select year view, also with a…
anna-lach 1874bed
fixing tests for disabled years
anna-lach 8931a06
fixing using arrow keys in the select year view, month view and selec…
anna-lach 8b6a206
problem with not closing the years range or months range when clickin…
anna-lach 3e1aac5
problem with not closing the years range or months range when clickin…
anna-lach ba45992
partially fixing focusing when years view closed and select month is …
anna-lach 1b05960
some more keyboard navigation improvements, readonly changes
anna-lach 821a5df
Merge remote-tracking branch 'origin/main' into feature/1862-calendar…
anna-lach aa5858f
fixing tests to work with vitest, new indicator story
anna-lach b9ee1b5
Merge remote-tracking branch 'origin/main' into feature/1862-calendar…
anna-lach 618a5ea
trying to get the new indicator working
anna-lach 85a33d3
Merge remote-tracking branch 'origin/main' into feature/1862-calendar…
anna-lach 18736b6
partially fixing indicators
anna-lach 76e413c
partially working disabled days
anna-lach 4adad7f
Merge remote-tracking branch 'origin/main' into feature/1862-calendar…
anna-lach b9f35bb
some styling improvements, disabled days are now being rendered prope…
anna-lach 99c3ab3
indicators stories fixes
anna-lach 57a5714
small changes to select year story
anna-lach acd2d88
stories changes, make it possible to select month and year and day in…
anna-lach e78bf9e
select month and select year unit tests
anna-lach fd85209
month view first version of tests and small change in month view
anna-lach 4aca9bc
month view unit tests changes
anna-lach fbc2c5d
examples improvements
anna-lach f68b29f
Merge remote-tracking branch 'origin/main' into feature/1862-calendar…
anna-lach f7e6805
mont view tests, fixing selecting day with space or enter key
anna-lach da6ebf6
fixes styling
anna-lach 9af50ab
some styling fixes, trying to solve the issue with selecting next/pre…
anna-lach 58a3186
styling improvements, solving the issue with selecting next/prev
anna-lach a4db8f0
trying to find the solution for keyboard navigation when going back f…
anna-lach b77a2d4
fixing the issue with lost focus in month view, trying to find the so…
anna-lach ba2e24a
trying to find the solution for keyboard navigation when trying to fo…
anna-lach 24f615d
fixing tests
anna-lach 2cc505f
select year improvements
anna-lach 212fc8d
select year improvements and some in select month
anna-lach 7f10411
select year and month changes, some accessibility improvements
anna-lach 63b7b90
some accessibility improvements
anna-lach 6bf1f10
using table instead of list in select month
anna-lach 3320559
select month accessibility improvements
anna-lach b19bf19
select year accessibility improvements (table instead of list and so …
anna-lach 9556638
select day and month view accessibility improvements
anna-lach e5f42bc
more accessibility improvements (tooltips for indicators to improve a…
anna-lach 9465385
more accessibility improvements, some cleanup
anna-lach 59e0193
some refactor
anna-lach 428f95a
alphabetical order
anna-lach 6f07b16
announcer - first version, used in select day
anna-lach 245f738
announcer in select day, select month and select year
anna-lach 7d06b52
translations
anna-lach 2c3f7b8
Merge remote-tracking branch 'origin/main' into feature/1862-calendar…
anna-lach b09729b
more unit tests, some problems with indicators
anna-lach f8d00a7
tooltips for indicators fixes (using tooltip.lazy), some formatting
anna-lach 8f52db4
Merge remote-tracking branch 'origin/main' into feature/1862-calendar…
anna-lach 3fc9086
unit tests
anna-lach a71d3e4
Merge remote-tracking branch 'origin/main' into feature/1862-calendar…
anna-lach 3d69773
unit tests (improvements)
anna-lach b0f22f0
unit tests (improvements)
anna-lach b179f03
remove unnecessary changes
anna-lach f486681
remove unnecessary changes
anna-lach 3fe0f4a
remove unnecessary changes
anna-lach bdd596d
fixing failing tests?
anna-lach fbcfdcb
fixing failing tests
anna-lach d166350
fixing failing tests?
anna-lach 8c73da3
fixing failing tests?
anna-lach 6371a95
fixing failing tests?
anna-lach bd67964
fixing failing tests?
anna-lach 6276849
fixing tests?
anna-lach 77948ff
some improvements, cleanup
anna-lach 3233478
changeset
anna-lach 7806c79
fixing tests?
anna-lach 46af954
Merge remote-tracking branch 'origin/main' into feature/1862-calendar…
anna-lach 20f8c2d
removed unnecessary attributes
anna-lach b74a14b
clicking outside the component removed
anna-lach af65d46
indicator renamed to indicatorDays, tooltip added only when the label…
anna-lach 6694831
disabled renamed to disabledDates
anna-lach 979b92f
removed icon size, no months class, tests fixes
anna-lach 4a8808b
more changes after review
anna-lach 75642f2
Merge remote-tracking branch 'origin/main' into feature/1862-calendar…
anna-lach 61ebd26
Merge remote-tracking branch 'origin/main' into feature/1862-calendar…
anna-lach d98412e
fixing shaky scrolling
anna-lach 3d2730c
blocking scrolling when moving to next and previous month is not poss…
anna-lach 3ebdee7
trying to improve block scrolling
anna-lach ac2e9e5
partially improved blocking scrolling
anna-lach 402be13
partially improved blocking scrolling (hiding unselectable months)
anna-lach 5807a1c
partially improved blocking scrolling
anna-lach 842aeb4
Merge remote-tracking branch 'origin/main' into feature/1862-calendar…
anna-lach 944589b
block scrolling when month is unselectable changes, some cleanup
anna-lach e0ba109
🍦
jpzwarte ec17c94
Merge branch 'main' into feature/1862-calendar-development
jpzwarte 74cabea
🍌
jpzwarte 20cf0c8
👻
jpzwarte cf4efe9
🚎
jpzwarte c83a0d9
🐒
jpzwarte e98a0ce
🐘
jpzwarte 255bf0a
🏜
jpzwarte 7f8a952
🏅
jpzwarte b925c21
🐺
jpzwarte 4aa02dd
🌮
jpzwarte ba22ca4
🚨
jpzwarte aa736ff
🐗
jpzwarte 0aa133f
🌶
jpzwarte 2d5b21b
⛸
jpzwarte 96fe269
🐄
jpzwarte fc199ae
🍯
jpzwarte c513a96
🏑
jpzwarte d16a250
🎤
jpzwarte 9fae9c3
👽
jpzwarte 4a7abbc
😀
jpzwarte e95968a
Merge branch 'main' into feature/1862-calendar-development
jpzwarte 6c3a5a0
🎾
jpzwarte 7c9798c
⚡️
jpzwarte 54183e7
💾
jpzwarte a9a34a4
🌻
jpzwarte 4c80926
🎡
jpzwarte 879c589
🌀
jpzwarte 13ea017
🏹
jpzwarte 52f8cde
📟
jpzwarte 632ddd6
🐯
jpzwarte c8907ac
📌
jpzwarte 760f1ba
🔮
jpzwarte dc07c1c
🍎
jpzwarte e101fb7
🐸
jpzwarte 637254e
🎷
jpzwarte File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@sl-design-system/shared': minor | ||
| --- | ||
|
|
||
| New `dateListConverter` added. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@sl-design-system/calendar': patch | ||
| --- | ||
|
|
||
| New version of the calendar component. Improved styling and accessibility. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@sl-design-system/date-field': patch | ||
| --- | ||
|
|
||
| Make a date-field working with dates (not dates and hours). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,2 @@ | ||
| export * from './src/announce.js'; | ||
| export * from './src/announcer.js'; | ||
| export { announce } from './src/announce.js'; | ||
| export { type SlAnnounceEvent, Announcer } from './src/announcer.js'; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.