dotnet/sdk Release candidate #956
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # site/static/code_snippets/getting_started/multiple_events.csharpsnippet # site/static/code_snippets/getting_started/setup.csharpsnippet # site/static/code_snippets/going_deeper/multiple_events.csharpsnippet # site/static/code_snippets/how_tos/load_more.csharpsnippet # site/static/code_snippets/how_tos/polling_1.csharpsnippet # site/static/code_snippets/how_tos/polling_2.csharpsnippet # site/static/code_snippets/how_tos/redirect_1.csharpsnippet # site/static/code_snippets/how_tos/redirect_2.csharpsnippet
|
Please provide a description of the changes. |
|
@bencroker |
|
I see you’re still making changes. Let me know when this is ready to merge. |
|
Ready! Anything else will be minor and will come after. |
|
Merged, thanks! |
wiserockryan
reviewed
Jul 7, 2025
| { | ||
| Task StartServerEventStreamAsync(IEnumerable<KeyValuePair<string, StringValues>> additionalHeaders); | ||
| Task StartServerEventStreamAsync(IEnumerable<KeyValuePair<string, string>> additionalHeaders); | ||
| Task StartServerEventStreamAsync(IEnumerable<KeyValuePair<string, StringValues>>? additionalHeaders = null); |
There was a problem hiding this comment.
Should these methods accept an optional CancellationToken?
There was a problem hiding this comment.
This PR is closed. Please create a new issue if you’d like to discuss further.
There was a problem hiding this comment.
Should these methods accept an optional
CancellationToken?
@wiserockryan, I can take care of this on the weekend.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates for the dotnet SDKs (F# and C#)