Skip to content

dotnet/sdk Release candidate #956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jul 6, 2025
Merged

dotnet/sdk Release candidate #956

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
951d8db
sdk/dotnet - merge to patch, fragment to element. IDatastarService in…
SpiralOSS Jun 20, 2025
9fb474e
sdk/dotnet - snippets updated
SpiralOSS Jun 20, 2025
64e9b38
sdk/dotnet - Examples updated
SpiralOSS Jun 20, 2025
e5aaeed
sdk/dotnet-nugets - renamed the workflows for creating nugets
SpiralOSS Jun 20, 2025
57cdfda
sdk/dotnet - avoid repeated locking. avoid out of order sses
SpiralOSS Jun 23, 2025
00aca7d
Merge branch 'starfederation:release-candidate' into release-candidate
SpiralOSS Jul 4, 2025
4fc654a
sdk/dotnet - zero allocation updates
SpiralOSS Jul 5, 2025
7a32019
sdk/dotnet - Consts updated
SpiralOSS Jul 5, 2025
92aa0ae
sdk/dotnet - even more optimizations on c# side
SpiralOSS Jul 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions sdk/dotnet/csharp/src/DependencyInjection/Services.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,20 +7,20 @@ namespace StarFederation.Datastar.DependencyInjection;

public interface IDatastarService
{
Task StartServerEventStreamAsync(IEnumerable<KeyValuePair<string, StringValues>> additionalHeaders);
Task StartServerEventStreamAsync(IEnumerable<KeyValuePair<string, string>> additionalHeaders);
Task StartServerEventStreamAsync(IEnumerable<KeyValuePair<string, StringValues>>? additionalHeaders = null);
Copy link

@wiserockryan wiserockryan Jul 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should these methods accept an optional CancellationToken?

Copy link
Collaborator

@bencroker bencroker Jul 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is closed. Please create a new issue if you’d like to discuss further.

Copy link
Contributor Author

@SpiralOSS SpiralOSS Jul 9, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should these methods accept an optional CancellationToken?

@wiserockryan, I can take care of this on the weekend.

Task StartServerEventStreamAsync(IEnumerable<KeyValuePair<string, string>>? additionalHeaders = null);

Task PatchElementsAsync(string fragments, PatchElementsOptions? options = null);

Task RemoveElementAsync(string selector, RemoveFragmentOptions? options = null);
Task RemoveElementAsync(string selector, RemoveElementOptions? options = null);

/// <summary>
/// Note: If TType is string then it is assumed that it is an already serialized Signals, otherwise serialize with jsonSerializerOptions
/// </summary>
Task PatchSignalsAsync<TType>(TType signals, JsonSerializerOptions? jsonSerializerOptions = null, PatchSignalsOptions? patchSignalsOptions = null);

/// <summary>
/// Execute a JS script on the client. Note: Do NOT include "&lt;script&gt;" encapsulation
/// Execute a JS script on the client. Note: Do NOT include "&lt;script&gt;" encapsulation
/// </summary>
Task ExecuteScriptAsync(string script, ExecuteScriptOptions? options = null);

Expand All @@ -44,23 +44,23 @@ public interface IDatastarService

internal class DatastarService(Core.ServerSentEventGenerator serverSentEventGenerator) : IDatastarService
{
public Task StartServerEventStreamAsync(IEnumerable<KeyValuePair<string, StringValues>> additionalHeaders) =>
public Task StartServerEventStreamAsync(IEnumerable<KeyValuePair<string, StringValues>>? additionalHeaders) =>
serverSentEventGenerator.StartServerEventStreamAsync(additionalHeaders ?? []);

public Task StartServerEventStreamAsync(IEnumerable<KeyValuePair<string, string>> additionalHeaders) =>
public Task StartServerEventStreamAsync(IEnumerable<KeyValuePair<string, string>>? additionalHeaders) =>
serverSentEventGenerator.StartServerEventStreamAsync(additionalHeaders?.Select(kvp => new KeyValuePair<string, StringValues>(kvp.Key, new StringValues(kvp.Value))) ?? []);

public Task PatchElementsAsync(string fragments, PatchElementsOptions? options = null) =>
serverSentEventGenerator.PatchElementsAsync(fragments, options ?? new());
serverSentEventGenerator.PatchElementsAsync(fragments, options ?? Core.PatchElementsOptions.Defaults);

public Task RemoveElementAsync(string selector, RemoveFragmentOptions? options = null) =>
serverSentEventGenerator.RemoveElementAsync(selector, options ?? new());
public Task RemoveElementAsync(string selector, RemoveElementOptions? options = null) =>
serverSentEventGenerator.RemoveElementAsync(selector, options ?? Core.RemoveElementOptions.Defaults);

public Task PatchSignalsAsync<TType>(TType signals, JsonSerializerOptions? jsonSerializerOptions = null, PatchSignalsOptions? patchSignalsOptions = null) =>
serverSentEventGenerator.PatchSignalsAsync(signals as string ?? JsonSerializer.Serialize(signals, jsonSerializerOptions), patchSignalsOptions ?? new());
serverSentEventGenerator.PatchSignalsAsync(signals as string ?? JsonSerializer.Serialize(signals, jsonSerializerOptions), patchSignalsOptions ?? Core.PatchSignalsOptions.Defaults);

public Task ExecuteScriptAsync(string script, ExecuteScriptOptions? options = null) =>
serverSentEventGenerator.ExecuteScriptAsync(script, options ?? new());
serverSentEventGenerator.ExecuteScriptAsync(script, options ?? Core.ExecuteScriptOptions.Defaults);

public Stream GetSignalsStream() => serverSentEventGenerator.GetSignalsStream();

Expand Down
8 changes: 4 additions & 4 deletions sdk/dotnet/csharp/src/DependencyInjection/Types.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,16 +54,16 @@ public class PatchSignalsOptions
options.Retry);
}

public class RemoveFragmentOptions
public class RemoveElementOptions
{
public bool UseViewTransition { get; init; } = Consts.DefaultElementsUseViewTransitions;
public string? EventId { get; init; } = null;
public TimeSpan Retry { get; init; } = Consts.DefaultSseRetryDuration;

public static implicit operator Core.RemoveElementOptions(RemoveFragmentOptions options) => ToFSharp(options);
public static implicit operator FSharpValueOption<Core.RemoveElementOptions>(RemoveFragmentOptions options) => ToFSharp(options);
public static implicit operator Core.RemoveElementOptions(RemoveElementOptions options) => ToFSharp(options);
public static implicit operator FSharpValueOption<Core.RemoveElementOptions>(RemoveElementOptions options) => ToFSharp(options);

private static Core.RemoveElementOptions ToFSharp(RemoveFragmentOptions options) => new(
private static Core.RemoveElementOptions ToFSharp(RemoveElementOptions options) => new(
options.UseViewTransition,
options.EventId ?? FSharpValueOption<string>.ValueNone,
options.Retry);
Expand Down
Loading