Add Release Github-Action #181
Conversation
|
Hey, should this template rolled every sunpy packages |
ankitkhushwaha
force-pushed
the
release-workflow
branch
from
7e8029f to
089fedb
Compare
ankitkhushwaha
force-pushed
the
release-workflow
branch
from
0bb9ae7 to
2a66e05
Compare
| secrets: | ||
| pypi_token: {{ '${{ secrets.pypi_token }}' }} | ||
| {%- if cookiecutter.github_repo in cookiecutter.all_repos %} | ||
| release: |
There was a problem hiding this comment.
the release workflow will now be updated in particular packages.
There was a problem hiding this comment.
the needed repos are taken from this
There was a problem hiding this comment.
the release is published in these packages. (Seen a list of repos in package-template/tools/batchpr_manual_cruft_update.py)
"all_repos": ["sunpy/sunpy", "sunpy/ndcube", "sunpy/sunkit-magex", "sunpy/streamtracer", "sunpy/sunkit-dem",
"sunpy/mpl-animators", "sunpy/sunkit-image", "sunpy/sunkit-pyvista", "sunpy/sunpy-soar", "sunpy/sunkit- "sunpy/drms", "sunpy/sunraster", "sunpy/sunkit-spex", "sunpy/radiospectra"]
thats' why i thought only to sync release workflow code in these packages only.
There was a problem hiding this comment.
But why does it need to be synced to those packages? What happens if we add more?
There was a problem hiding this comment.
there are some packages like data, sunpy-1.0-paper, github-actions-workflows, where i think there is no need to add the release workflow code in these repo.
Should i remove this line ?
There was a problem hiding this comment.
Are those repositories tempted? Do they ever get a release?
There was a problem hiding this comment.
sunpy-paper has release but it is archived now.
data doesn't have release
ankitkhushwaha
force-pushed
the
release-workflow
branch
from
67c4ec3 to
f733cc1
Compare
2 participants
PR Description
see #8061