-
-
Notifications
You must be signed in to change notification settings - Fork 9
Add Release Github-Action #181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ankitkhushwaha
wants to merge
1
commit into
sunpy:main
Choose a base branch
from
ankitkhushwaha:release-workflow
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -122,3 +122,34 @@ jobs: | |
| {%- endif %} | ||
| secrets: | ||
| pypi_token: {{ '${{ secrets.pypi_token }}' }} | ||
| {%- if cookiecutter.github_repo in cookiecutter.all_repos %} | ||
| release: | ||
| if: startsWith(github.ref, 'refs/tags/v') | ||
| runs-on: ubuntu-latest | ||
| permissions: | ||
| contents: write | ||
| actions: none | ||
| checks: none | ||
| deployments: none | ||
| steps: | ||
| - name: Checkout repository | ||
| uses: actions/checkout@v3 | ||
| - name: Install Pandoc | ||
| run: sudo apt-get update && sudo apt-get install -y pandoc | ||
| - name: Generate GitHub Release Notes | ||
| run: | | ||
| pip install bleach | ||
| pandoc --wrap=none -t markdown_strict CHANGELOG.rst > notes.md | ||
| python3 -c "import bleach, sys; print(bleach.clean(sys.stdin.read()))" < notes.md > release_notes.md | ||
| { echo "RELEASE_BODY<<EOF"; cat release_notes.md; echo "EOF"; } >> $GITHUB_ENV | ||
| - name: Create GitHub Release | ||
| uses: "actions/[email protected]" | ||
| env: | ||
| GITHUB_TOKEN: {{ '${{ secrets.GITHUB_TOKEN }}' }} | ||
| with: | ||
| tag_name: {{ '${{ github.ref }}' }} | ||
| release_name: {{ '${{ github.ref_name }}' }} | ||
| body: {{ '${{ env.RELEASE_BODY }}' }} | ||
| draft: false | ||
| prerelease: false | ||
| {%- endif %} | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the release workflow will now be updated in particular packages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the needed repos are taken from this
package-template/tools/batchpr_manual_cruft_update.py
Line 30 in 9749d8e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the reason for this?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the release is published in these packages. (Seen a list of repos in package-template/tools/batchpr_manual_cruft_update.py)
thats' why i thought only to sync release workflow code in these packages only.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But why does it need to be synced to those packages? What happens if we add more?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there are some packages like
data, sunpy-1.0-paper, github-actions-workflows, where i think there is no need to add the release workflow code in these repo.Should i remove this line ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are those repositories tempted? Do they ever get a release?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sunpy-paper has release but it is archived now.
data doesn't have release