dms_s3_endpoint: fix enum validations #991
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bendrucker
force-pushed
the
fix-dms-s3-endpoint-mappings
branch
from
9b91617 to
7f52256
Compare
bendrucker
changed the title
bendrucker
changed the title
bendrucker
force-pushed
the
fix-dms-s3-endpoint-mappings
branch
from
7f52256 to
f544f70
Compare
Fixes #989 The `aws_dms_s3_endpoint` mapping was accidentally removed during the Smithy migration in #901. This restores the mapping and adds support for transforming enum values to match Terraform provider expectations. ## Changes ### Mapping restoration - Add `aws_dms_s3_endpoint` mapping to `dms.hcl` - Generate validation rules for 8 attributes (compression_type, encryption_mode, data_format, encoding_type, parquet_version, date_partition_sequence, date_partition_delimiter, canned_acl_for_objects) ### Transform system - Implement HCL function-based transform system in generator - Use `uppercase()` and `replace()` functions directly in mapping expressions - Leverage HCL's `EvalContext` with custom list-transform wrappers ### Enum value corrections - `compression_type`: Smithy "none"/"gzip" → Terraform "NONE"/"GZIP" - `encryption_mode`: Smithy "sse-kms"/"sse-s3" → Terraform "SSE_KMS"/"SSE_S3" - Other enums similarly transformed to uppercase This approach keeps transform logic declarative in the mapping files rather than hardcoded in the generator, making it maintainable and extensible for future cases where Smithy and Terraform enum formats differ.
bendrucker
force-pushed
the
fix-dms-s3-endpoint-mappings
branch
from
f544f70 to
869771f
Compare
bendrucker
added a commit
that referenced
this pull request
Nov 21, 2025
Adds comprehensive test coverage for the HCL transform system introduced in #991: - Unit tests for stringsToCtyList helper - Tests for makeListTransformFunction with uppercase and replace - Error case testing for invalid inputs - Transform composition tests Improves error handling and code quality: - Enhanced error messages showing variable names when multiple variables referenced - Clean eval context handling using fresh variable maps instead of deletion - Pre-allocated slices for better performance - Proper empty list handling in cty conversions - Comprehensive documentation of transform system All tests pass and generator continues to work correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
aws_dms_s3_endpointmapping was accidentally removed during the Smithy migration in #901, causing validation rules for this resource to be deleted. This restores the mapping and adds an HCL function-based transform system to handle enum value differences between Smithy models and the Terraform provider to fix mismatched enum values. This problem predated Smithy and is a persistent difference between how the TF provider and the AWS API models represent this attribute.Changes
aws_dms_s3_endpointmapping indms.hclwith validation for 8 attributesEvalContextuppercase()andreplace()transform functions usable directly in mapping expressionscompression_type: "none"/"gzip" → "NONE"/"GZIP"encryption_mode: "sse-kms"/"sse-s3" → "SSE_KMS"/"SSE_S3"The transform system leverages HCL's built-in
EvalContextwith custom list-transform function wrappers around stdlib'sUpperFuncandReplaceFunc. This keeps transform logic declarative in mapping files rather than hardcoded in the generator, making it extensible for future cases where Smithy and Terraform formats differ.References
Closes #989