saop pushdown experiments #8290
Draft
+293
−50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8290 +/- ##
==========================================
- Coverage 82.53% 80.58% -1.96%
==========================================
Files 249 249
Lines 48286 46940 -1346
Branches 12318 12199 -119
==========================================
- Hits 39855 37826 -2029
- Misses 3494 4230 +736
+ Partials 4937 4884 -53 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was not handled properly.
For now, nothing is pushed down.
No functional changes. Bring qual_pushdown_mutator() and the individual pushdown functions to the same interface as expression_tree_mutator() (no NULL returns + using context.can_pushdown) to avoid accidental errors. Reorganize the code a little to make adding new pushdown optimizations easier.
Ignore the Postgres planner directive, because our vectorized check still seems to be faster than hashing up to about 32 elements.
This improves the bloom filter detoasting performance. Also cache some more things like the hash function while we have this per-function context.
|
This pull request has been automatically marked as stale due to lack of activity. This pull request will be closed in 30 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parts: