Skip to content

fix(code-quality): correct favicon path to load properly in deep routes #705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(code-quality): correct favicon path to load properly in deep routes #705

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion fundamentals/code-quality/.vitepress/shared.mts
View file
Open in desktop
Copy link

@kss2002 kss2002 Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You changed the route, so what do you think the ico of the site looks like locally by suinkimme?

I look like this in the version I don't change.

토스

Thank you

Copy link
Author

@suinkimme suinkimme Nov 28, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code-quality의 쀑첩 κ²½λ‘œμ—μ„œλ§Œ favicon이 λ Œλ”λ§λ˜μ§€ μ•ŠλŠ” μ΄μŠˆκ°€ μžˆμ—ˆμŠ΅λ‹ˆλ‹€. 이전 νŽ˜μ΄μ§€μ—μ„œ κ°€μ Έμ˜¨ favicon μΊμ‹œ λ•Œλ¬Έμ— 일뢀 μƒν™©μ—μ„œλŠ” μ •μƒμ μœΌλ‘œ λ³΄μ΄λŠ” κ²ƒμ²˜λŸΌ 보이기도 ν–ˆμŠ΅λ‹ˆλ‹€.
μ–΄λ–€ κ²½λ‘œμ—μ„œλ„ favicon이 μ˜¬λ°”λ₯΄κ²Œ λ‘œλ“œλ˜λ„λ‘ μˆ˜μ •ν–ˆκ³ , ν•΄λ‹Ή λ³€κ²½ μ‚¬ν•­μœΌλ‘œ PR도 μ˜¬λ ΈμŠ΅λ‹ˆλ‹€. μΆ”κ°€λ‘œ μ›ν•˜μ‹œλŠ” 점이 μžˆλ‹€λ©΄ μ•Œλ €μ£Όμ„Έμš”!

μ œκ°€ μ˜μ–΄κ°€ μœ μ°½ν•œ 편이 μ•„λ‹ˆλΌ ν˜Ήμ‹œ ν•œκ΅­μ–΄λ‘œ μ–΄λ–€ μ΄μŠˆκ°€ μžˆμœΌμ…¨λŠ”μ§€ λ‹€μ‹œ ν•œ 번 말씀해주싀 수 μžˆμœΌμ‹ κ°€μš”?

Copy link

@kss2002 kss2002 Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μ € λ˜ν•œ μΊμ‹œμ˜ 영ν–₯인지 μ •μƒμ μœΌλ‘œ icoκ°€ λ‘œλ“œλ˜λŠ” 상황이 μΌμ–΄λ‚˜κΈ°λ„ ν•˜κ³ , icoκ°€ μ—†λŠ” 상황도 λ°œμƒν•©λ‹ˆλ‹€.
λ‹€λ₯Έ μ‚¬λžŒλ“€λ„ λ™μΌν•˜κ²Œ λœ¨λŠ”μ§€, 그리고 μ½”λ“œλ₯Ό 고쳀을 λ•Œμ— 영ꡬ적으둜 icoκ°€ 잘 λœ¨λŠ”μ§€κ°€ κΆκΈˆν•΄μ„œ μ—¬μ­ˆμ–΄λ³΄μ•˜μŠ΅λ‹ˆλ‹€!

κ°μ‚¬ν•©λ‹ˆλ‹€.

Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ export const shared = defineConfig({
{
rel: "icon",
type: "image/x-icon",
href: "images/favicon.ico"
href: "/code-quality/images/favicon.ico"
}
],
["link", { rel: "manifest", href: "images/site.webmanifest" }],
Expand Down