Fix SendableMetatype handling #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MahdiBM
approved these changes
Sep 8, 2025
MahdiBM
reviewed
Sep 8, 2025
| public typealias _SQLKitExtrasSendableMetatype = Any | ||
| #endif | ||
|
|
||
| extension FluentKit.FieldProperty: _SQLKitExtrasSendableMetatype {} |
Member
Author
There was a problem hiding this comment.
Yes. Once the protocol became a typealias, it wasn't needed; the Sendable on the original property covered it all along. Now the addition is only made to the property wrappers that aren't already Sendable (it's still not a great solution, but Fluent 4 is a hopeless mess for Concurrency anyway).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
SendableMetatypething I did in the previous PR wasn't quite right. This fixes it.