Skip to content

Fix SendableMetatype handling #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gwynne merged 1 commit into from
Sep 8, 2025
Merged

Fix SendableMetatype handling #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions Sources/FluentKitExtras/SwiftCompatibility.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,18 @@
import FluentKit

#if compiler(>=6.2)
@_marker public protocol _SQLKitExtrasSendableMetatype: SendableMetatype {}
public typealias _SQLKitExtrasSendableMetatype = SendableMetatype
#else
@_marker public protocol _SQLKitExtrasSendableMetatype {}
public typealias _SQLKitExtrasSendableMetatype = Any
#endif

extension FluentKit.FieldProperty: _SQLKitExtrasSendableMetatype {}
Copy link

@MahdiBM MahdiBM Sep 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed this one?

Copy link
Member Author

@gwynne gwynne Sep 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Once the protocol became a typealias, it wasn't needed; the Sendable on the original property covered it all along. Now the addition is only made to the property wrappers that aren't already Sendable (it's still not a great solution, but Fluent 4 is a hopeless mess for Concurrency anyway).

extension FluentKit.BooleanProperty: _SQLKitExtrasSendableMetatype {}
extension FluentKit.OptionalBooleanProperty: _SQLKitExtrasSendableMetatype {}

extension FlatGroupProperty: _SQLKitExtrasSendableMetatype {}
extension OptionalPointerProperty: _SQLKitExtrasSendableMetatype {}
extension OptionalReferenceProperty: _SQLKitExtrasSendableMetatype {}
extension PointerProperty: _SQLKitExtrasSendableMetatype {}
extension ReferencesProperty: _SQLKitExtrasSendableMetatype {}
extension RequiredTimestampProperty: _SQLKitExtrasSendableMetatype {}