Skip to content

Conversation

@MengqingCao
Copy link
Collaborator

@MengqingCao MengqingCao commented Nov 29, 2025

What this PR does / why we need it?

Skip test_ngram_correctness as the oom issue block CI
related CI failure: https://github.com/vllm-project/vllm-ascend/actions/runs/19780591780/job/56680823606

Does this PR introduce any user-facing change?

N/A

@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:‌‌

  • A PR should do only one thing, smaller PRs enable faster reviews.
  • Every PR should include unit tests and end-to-end tests ‌to ensure it works and is not broken by other future PRs.
  • Write the commit message by fulfilling the PR description to help reviewer and future developers understand.

If CI fails, you can run linting and testing checks locally according Contributing and Testing.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request temporarily disables test_ngram_correctness to resolve an Out-Of-Memory (OOM) issue that is blocking the CI pipeline. While this is a practical short-term solution, my review includes a suggestion to improve the tracking of this disabled test by linking it to a formal issue. This will help ensure the underlying OOM problem is addressed and the test is re-enabled in a timely manner.

return "vllm-ascend/EAGLE3-LLaMA3.1-Instruct-8B"


@pytest.mark.skip("TODO: Revert me after ngram oom issue on ci is fixed")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

While skipping the test is a reasonable temporary measure to unblock CI, using a TODO comment alone can make it difficult to track and resolve the underlying OOM issue. To improve visibility and ensure this test is eventually re-enabled, it's highly recommended to create a tracking issue (e.g., a GitHub issue) and reference its number in the skip message. This makes it much easier for the team to follow up on fixing the OOM problem.

Suggested change
@pytest.mark.skip("TODO: Revert me after ngram oom issue on ci is fixed")
@pytest.mark.skip("Skipping to unblock CI due to OOM. See issue #<issue_number> for tracking.")

@MengqingCao MengqingCao added ready read for review ready-for-test start test by label for PR labels Nov 29, 2025
@weijinqian0 weijinqian0 merged commit c84efea into vllm-project:main Nov 29, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module:tests ready read for review ready-for-test start test by label for PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants