Skip to content

[CI] Skip test_ngram_correctness as the oom issue block CI #4578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 29, 2025
+1 −0
Merged

[CI] Skip test_ngram_correctness as the oom issue block CI #4578

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions tests/e2e/singlecard/spec_decode_v1/test_v1_spec_decode.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ def eagle3_model_name():
return "vllm-ascend/EAGLE3-LLaMA3.1-Instruct-8B"


@pytest.mark.skip("TODO: Revert me after ngram oom issue on ci is fixed")
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Nov 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

While skipping the test is a reasonable temporary measure to unblock CI, using a TODO comment alone can make it difficult to track and resolve the underlying OOM issue. To improve visibility and ensure this test is eventually re-enabled, it's highly recommended to create a tracking issue (e.g., a GitHub issue) and reference its number in the skip message. This makes it much easier for the team to follow up on fixing the OOM problem.

Suggested change
@pytest.mark.skip("TODO: Revert me after ngram oom issue on ci is fixed")
@pytest.mark.skip("Skipping to unblock CI due to OOM. See issue #<issue_number> for tracking.")

def test_ngram_correctness(
test_prompts: list[list[dict[str, Any]]],
sampling_config: SamplingParams,
Expand Down
Loading