Skip to content

Conversation

@TingW09
Copy link
Contributor

@TingW09 TingW09 commented Dec 16, 2025

What this PR does / why we need it?

add qwen3 reranker tutorials

Does this PR introduce any user-facing change?

How was this patch tested?

  • vLLM version: v0.12.0

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds documentation for the Qwen3 Reranker model and refactors the existing documentation for the Qwen3 Embedding model. The changes improve the structure and clarity of the documentation. However, there are a few issues that need to be addressed: several sections are left as placeholders, there's a typo in a URL that breaks it, and some internal links are broken due to incorrect casing in file paths. Addressing these will ensure the documentation is complete and accurate.

Comment on lines 164 to 165
## Performance
will be provided later... No newline at end of file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The "Performance" section is added as a placeholder. For a documentation PR, it's important to provide complete information. If the data is not yet available, please consider adding a note with a link to a tracking issue or an estimated timeline for when this information will be provided.

Comment on lines 49 to 50
| Qwen3-Embedding || [Qwen3-Embedding tutorials](../../tutorials/Qwen3-Embedding.md) |||||||||||||||||||
| Qwen3-Reranker || [Qwen3-Reranker tutorials](../../tutorials/Qwen3-Reranker.md) |||||||||||||||||||
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The links to the tutorials for Qwen3-Embedding and Qwen3-Reranker are broken due to incorrect casing in the filenames. The filenames use lowercase embedding and reranker, but the links use uppercase Embedding and Reranker. File paths are case-sensitive on many systems.

Suggested change
| Qwen3-Embedding || [Qwen3-Embedding tutorials](../../tutorials/Qwen3-Embedding.md) |||||||||||||||||||
| Qwen3-Reranker || [Qwen3-Reranker tutorials](../../tutorials/Qwen3-Reranker.md) |||||||||||||||||||
| Qwen3-Embedding || [Qwen3-Embedding tutorials](../../tutorials/Qwen3_embedding.md) |||||||||||||||||||
| Qwen3-Reranker || [Qwen3-Reranker tutorials](../../tutorials/Qwen3_reranker.md) |||||||||||||||||||

@TingW09 TingW09 changed the title [Doc] add qwen3 rerankrt Signed-off-by:TingW09 <[email protected]> [Doc] add qwen3 rerankrt Signed-off-by Dec 16, 2025
@TingW09 TingW09 changed the title [Doc] add qwen3 rerankrt Signed-off-by [Doc] add qwen3 rerankrt Dec 16, 2025
@TingW09 TingW09 marked this pull request as draft December 16, 2025 08:18
@TingW09 TingW09 changed the title [Doc] add qwen3 rerankrt [Doc] add qwen3 reranker Dec 16, 2025
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Dec 16, 2025
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:‌‌

  • A PR should do only one thing, smaller PRs enable faster reviews.
  • Every PR should include unit tests and end-to-end tests ‌to ensure it works and is not broken by other future PRs.
  • Write the commit message by fulfilling the PR description to help reviewer and future developers understand.

If CI fails, you can run linting and testing checks locally according Contributing and Testing.

@TingW09 TingW09 marked this pull request as ready for review December 17, 2025 02:25
@wangxiyuan wangxiyuan merged commit 879ec2d into vllm-project:main Dec 18, 2025
16 checks passed
chenaoxuan pushed a commit to chenaoxuan/vllm-ascend that referenced this pull request Dec 20, 2025
### What this PR does / why we need it?
add qwen3 reranker tutorials
### Does this PR introduce _any_ user-facing change?

### How was this patch tested?

- vLLM version: v0.12.0

---------

Signed-off-by: TingW09 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants