-
Notifications
You must be signed in to change notification settings - Fork 671
[Doc] add qwen3 reranker #5086
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Doc] add qwen3 reranker #5086
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds documentation for the Qwen3 Reranker model and refactors the existing documentation for the Qwen3 Embedding model. The changes improve the structure and clarity of the documentation. However, there are a few issues that need to be addressed: several sections are left as placeholders, there's a typo in a URL that breaks it, and some internal links are broken due to incorrect casing in file paths. Addressing these will ensure the documentation is complete and accurate.
| ## Performance | ||
| will be provided later... No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| | Qwen3-Embedding | ✅ | [Qwen3-Embedding tutorials](../../tutorials/Qwen3-Embedding.md) ||||||||||||||||||| | ||
| | Qwen3-Reranker | ✅ | [Qwen3-Reranker tutorials](../../tutorials/Qwen3-Reranker.md) ||||||||||||||||||| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The links to the tutorials for Qwen3-Embedding and Qwen3-Reranker are broken due to incorrect casing in the filenames. The filenames use lowercase embedding and reranker, but the links use uppercase Embedding and Reranker. File paths are case-sensitive on many systems.
| | Qwen3-Embedding | ✅ | [Qwen3-Embedding tutorials](../../tutorials/Qwen3-Embedding.md) ||||||||||||||||||| | |
| | Qwen3-Reranker | ✅ | [Qwen3-Reranker tutorials](../../tutorials/Qwen3-Reranker.md) ||||||||||||||||||| | |
| | Qwen3-Embedding | ✅ | [Qwen3-Embedding tutorials](../../tutorials/Qwen3_embedding.md) ||||||||||||||||||| | |
| | Qwen3-Reranker | ✅ | [Qwen3-Reranker tutorials](../../tutorials/Qwen3_reranker.md) ||||||||||||||||||| |
b3970e5 to
95c6008
Compare
Signed-off-by: TingW09 <[email protected]>
95c6008 to
5658ff2
Compare
Signed-off-by: TingW09 <[email protected]>
fcb2157 to
e4d043e
Compare
Signed-off-by: TingW09 <[email protected]>
62eb7a1 to
8df52e2
Compare
|
👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:
If CI fails, you can run linting and testing checks locally according Contributing and Testing. |
Signed-off-by: TingW09 <[email protected]>
4cdb1f2 to
18af332
Compare
Signed-off-by: TingW09 <[email protected]>
0f3e7c9 to
576da22
Compare
Signed-off-by: TingW09 <[email protected]>
f804111 to
be0b660
Compare
Signed-off-by: TingW09 <[email protected]>
Signed-off-by: TingW09 <[email protected]>
Signed-off-by: TingW09 <[email protected]>
Signed-off-by: TingW09 <[email protected]>
### What this PR does / why we need it? add qwen3 reranker tutorials ### Does this PR introduce _any_ user-facing change? ### How was this patch tested? - vLLM version: v0.12.0 --------- Signed-off-by: TingW09 <[email protected]>
What this PR does / why we need it?
add qwen3 reranker tutorials
Does this PR introduce any user-facing change?
How was this patch tested?