[Hardware][AMD] Remove ROCm skip conditions for transformers backend tests #29782
Conversation
Signed-off-by: badaoui <[email protected]>
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request successfully removes skip conditions for transformers backend tests on the ROCm platform. The changes indicate that the previously failing tests, including those related to bitsandbytes quantization, now pass. This is a positive development, improving the overall compatibility and functionality of vLLM with ROCm. The removal of the current_platform import is a clean-up directly resulting from these changes.
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run You ask your reviewers to trigger select CI tests on top of Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add If you have any questions, please reach out to us on Slack at https://slack.vllm.ai. 🚀 |
hmellor
left a comment
hmellor
left a comment
There was a problem hiding this comment.
LGTM! Good to see the Transformers modelling backend becoming more compatible with ROCm!
Signed-off-by: badaoui <[email protected]>
Head branch was pushed to by a user without write access
github-actions
bot
added
the
ready
…tests (vllm-project#29782) Signed-off-by: badaoui <[email protected]> Signed-off-by: Hashem Hashemi <[email protected]>
…tests (vllm-project#29782) Signed-off-by: badaoui <[email protected]> Signed-off-by: Bofeng BF1 Xue <[email protected]>
…tests (vllm-project#29782) Signed-off-by: badaoui <[email protected]> Signed-off-by: Xingyu Liu <[email protected]>
3 participants
Summary
Removes skip conditions for transformers backend tests on ROCm platform. These tests now pass successfully, so the skips are no longer needed.
@hmellor