Skip to content

[Hardware][AMD] Remove ROCm skip conditions for transformers backend tests #29782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DarkLight1337 merged 2 commits into from
Dec 1, 2025
Merged

[Hardware][AMD] Remove ROCm skip conditions for transformers backend tests #29782

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
81493d2
Remove ROCm skip conditions for transformers backend tests
Abdennacer-Badaoui Dec 1, 2025
dcf2d2d
restore ROCm skip condition for bitsandbytes
Abdennacer-Badaoui Dec 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions tests/models/test_transformers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@

import pytest

from vllm.platforms import current_platform

from ..conftest import HfRunner, VllmRunner
from ..utils import multi_gpu_test, prep_prompts
from .registry import HF_EXAMPLE_MODELS
Expand Down Expand Up @@ -59,10 +57,6 @@ def check_implementation(
)


@pytest.mark.skipif(
current_platform.is_rocm(),
reason="Llama-3.2-1B-Instruct, Ilama-3.2-1B produce memory access fault.",
)
@pytest.mark.parametrize(
"model,model_impl",
[
Expand Down Expand Up @@ -147,12 +141,6 @@ def test_quantization(
max_tokens: int,
num_logprobs: int,
) -> None:
if (
current_platform.is_rocm()
and quantization_kwargs.get("quantization", "") == "bitsandbytes"
):
pytest.skip("bitsandbytes quantization is currently not supported in rocm.")

with vllm_runner(
model,
model_impl="auto",
Expand Down
Loading