Do not panic on duplicate declarations in decl-index #1314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead, we remove duplicate declarations from the `DeclIndex`, and issue respective warnings. Also, during selection, when a declaration is unavailable because it depends on an unavailable transitive dependency, we report the `SingleLoc` of the unavailable transitive dependency. This greatly eases finding the correct parse and select predicates.
dschrempf
force-pushed
the
dom/1155/duplicate-declarations
branch
from
82f67c3 to
2910847
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead, we remove duplicate declarations from the
DeclIndex, and issue respective warnings.Also, during selection, when a declaration is unavailable because it depends on an unavailable transitive dependency, we report the
SingleLocof the unavailable transitive dependency. This greatly eases finding the correct parse and select predicates.TODO:
SharedKeytrace (probably even use the same trace message type).TODO AFTER MERGE:
--parse-allrequired).