Add cases for non-compliant struct tag and remove go vet check from CI and Makefile

[SVilgelm]

Add test cases to decode_test.go and encode_test.go that cover an edge case described in issue #157 where a struct field uses an incorrect tag syntax (a bare string like bar without the yaml: prefix) alongside a correct yaml:"foo" tag. The new tests assert that the library continues to accept and round-trip values when one field uses the supported-but-nonstandard tag form.

This clarifies expected behavior and prevents regressions for legacy struct tags that some users rely on.

Remove the redundant go vet invocation from both the GitHub Actions
workflow and the GNUmakefile. The CI workflow no longer runs
"go vet ./..." and the "vet" target and its invocation in the makefile
are deleted.

Disable the Go vet tool when running test and helper commands
to avoid vet-related failures blocking test execution. Update the main
test target so its result parsing is not affected by vet output.

Fixes #157

[Copilot]

Pull Request Overview

This PR adds test cases to verify that the YAML library correctly handles and round-trips struct fields with non-standard tag syntax (bare strings without the yaml: prefix) alongside standard yaml: tags, addressing issue #157.

• Adds marshal test case for structs with mixed standard and non-standard tag formats
• Adds unmarshal test case for structs with mixed standard and non-standard tag formats

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
encode_test.go	Adds test case verifying marshaling behavior with non-compliant struct tags
decode_test.go	Adds test case verifying unmarshaling behavior with non-compliant struct tags

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[ccoVeille]

Some comments.

Please remove the go vet jobs from GHA and the govet in Makefile entry

You might also have to update go test calls use -vet=off as flags with GHA and Makefile, the govet linters in golangci-lint is enough and supports //nolint:govet as you said.

[ccoVeille]

Some comments.

Please remove the go vet jobs from GHA and the govet in Makefile entry

You might also have to update go test calls use -vet=off as flags with GHA and Makefile, the govet linters in golangci-lint is enough and supports //nolint:govet as you said.

About this ☝️

It reminds me your comment in the other issue 👇

The govet is automatic with go test

not really:

(…)

As you can see, I ran go test locally and it does not fail, but go vet fails.

Originally posted by @SVilgelm in #154 (comment)

I'm unsure how you got no errors as using go test uses go vet by default with Go 1.24+

https://go.dev/doc/go1.24#vet

[SVilgelm]

I don't know,

25-10-28 14:25 % go test ./...                                                                                                                                              
ok      go.yaml.in/yaml/v4      2.087s
?       go.yaml.in/yaml/v4/cmd/go-yaml  [no test files]
?       go.yaml.in/yaml/v4/internal/libyaml     [no test files]
ok      go.yaml.in/yaml/v4/internal/testutil/assert     0.615s
ok      go.yaml.in/yaml/v4/yts  1.099s

25-10-28 14:25 % go version                                                                                                                                                 
go version go1.24.9 darwin/arm64

Okay, I checked the documentation for test cmd, it says:

go test runs go vet on the package
and its test source files to identify significant problems.
...
To disable the running of go vet, use the -vet=off flag. To run all
checks, use the -vet=all flag.

Seems this particular check is disabled for test cmd. The vet tool is like golangci-lint, it also runs multiple analyzers.
To prove this idea, I run go test -vet=all and it failed.

[SVilgelm]

I got an idea, maybe instead of removing vet target from Makefile, I should change it to invoke golangci-lint?

[ccoVeille]

You could indeed this could do the job

golangci-lint run --enable-only govet

But, I'm unsure here. At least you would only have it in makefile and not the GHA.

I would simply remove it. But it doesn't mean I'm right about it. I get your point, I'm unsure what is the best.

As make lint is also available, I'm unsure there is a need for a make vet. I mean why having a vet target that doesn't call go vet, and call something that is also available and checked by lint target

If it is removed, there might be a need to update contributions guide.

Also, please consider adding -vet=off to go test in test target

[SVilgelm]

Looks like the the lint target is not merged yet: make: *** No rule to make target lint'`

[SVilgelm]

Also, please consider adding -vet=off to go test in test target

sure, will add

[ccoVeille]

Looks like the the lint target is not merged yet: make: *** No rule to make target lint'`

Indeed #131 is not merged yet.

[SVilgelm]

@ccoVeille @ingydotnet I rebased this PR and I think it is ready

[ingydotnet]

@ccoVeille @ingydotnet I rebased this PR and I think it is ready

@SVilgelm thanks. I'm out of tuits for this until at least Friday...

[ccoVeille]

Let's merge and continue with other PR.

It's a test we add and some addition to makefile