Feature/58 exam deployment service #77
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
ji-min0
force-pushed
the
feature/58-exam-deployment-service
branch
from
98ff653 to
2e7a894
Compare
ji-min0
force-pushed
the
feature/58-exam-deployment-service
branch
from
2e7a894 to
2f59487
Compare
ji-min0
force-pushed
the
feature/58-exam-deployment-service
branch
from
2f59487 to
308b5cd
Compare
ji-min0
force-pushed
the
feature/58-exam-deployment-service
branch
2 times, most recently
from
14ba3b8 to
d2586dc
Compare
- ValidationError를 string에서 dict로 변경 - 검증 함수로 묶어서 함수호출로 변경
- try-except로 non_field_error로 묶지않고 DeploymentValidator에서 발생시킨 예외 그대로 raise되도록 변경
- try-except로 non_field_error로 묶지않고 DeploymentValidator에서 발생시킨 예외 그대로 raise되도록 변경
- validate_not_closed 함수 제거
- exam - cohort 관계 검증 코드 서비스에서 시리얼라이저로 이동
- access_code는 read_only
- view에서 검증하도록 할 예정
ji-min0
force-pushed
the
feature/58-exam-deployment-service
branch
from
d2586dc to
322c6a8
Compare
Meoyoug
requested changes
Dec 15, 2025
Comment on lines
+135
to
+138
| for field, value in data.items(): | ||
| if field not in allowed_fields: | ||
| raise ValidationError({"field": "수정할 수 없는 필드입니다."}) | ||
| setattr(deployment, field, value) |
Collaborator
There was a problem hiding this comment.
시리얼라이저의 기본 동작 중에 선언되지 않은 필드에 대해서 키-밸류가 전달되면 해당 데이터는 무시되고 validate를 진행한 후에 validated_data가 생성됩니다
validated_data를 활용한다면 불필요한 절인 것 같아요
1yul2
reviewed
Dec 15, 2025
Comment on lines
+154
to
+163
| def test_set_status_after_closed(self) -> None: | ||
| deployment = self._create_default_deployment() | ||
| self._force_closed(deployment) | ||
|
|
||
| updated = set_deployment_status( | ||
| deployment=deployment, | ||
| status=DeploymentStatus.DEACTIVATED, | ||
| ) | ||
|
|
||
| self.assertEqual(updated.status, DeploymentStatus.DEACTIVATED) |
Collaborator
There was a problem hiding this comment.
요구사항 정의서 보시면 종료된 시험은 상태 변경 불가입니다.
테스트 코드에도 추가하셔서 테스트 진행해주세요
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ PR 요약
📄 상세 내용
🧪 PR Checklist