Allow 64-bit Mcause::from_bits on rv64 #334
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsgf
force-pushed
the
fix-mcause-interrupt
branch
3 times, most recently
from
827a55f to
eb6df01
Compare
romancardenas
requested changes
Jul 25, 2025
Contributor
romancardenas
left a comment
romancardenas
left a comment
There was a problem hiding this comment.
Thanks! In newer PRs, we are using usize::MAX instead of !0usize. Can you change this?
riscv/src/register/mcause.rs
Outdated
| /// `mcause` register | ||
| Mcause: 0x342, | ||
| mask: 0xffff_ffff, | ||
| mask: !0usize, |
Contributor
There was a problem hiding this comment.
Suggested change
| mask: !0usize, | |
| mask: usize::MAX, |
Contributor
|
Also, please rebase from master to fix conflicts on README file |
jsgf
force-pushed
the
fix-mcause-interrupt
branch
from
eb6df01 to
90cfc5f
Compare
jsgf
force-pushed
the
fix-mcause-interrupt
branch
from
90cfc5f to
877a83c
Compare
romancardenas
approved these changes
Jul 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the mcause mask to
!0u64on rv64 targets.Fixes #333