Update FFMPEG to use 6.1.1 #59
Conversation
|
It looks like OpenSSL has a compatibility issue in 1.3. The version needed by FFMPEG_jll does not exist for 1.3 |
|
|
||
| [compat] | ||
| FFMPEG_jll = "4.3.1" | ||
| FFMPEG_jll = "4.3.1, 6.1.1" |
There was a problem hiding this comment.
Hmmm.. I'm not sure about adding this in a patch release.
At least can we check VideoIO.jl tests before releasing this
There was a problem hiding this comment.
Hmmm.. I'm not sure about adding this in a patch release.
I agree, that would also mean moving the julia bound to 1.6
At least can we check VideoIO.jl tests before releasing this
By this do you mean testing locally?
There was a problem hiding this comment.
Maybe also move to v1.0.0 altogether, to avoid the mess of using only two version numbers, this package hasn't been touched in 3 years, looks moderately stable.
There was a problem hiding this comment.
By this do you mean testing locally?
You could edit the VideoIO CI to dev this branch and test on a PR
There was a problem hiding this comment.
Maybe also move to v1.0.0 altogether, to avoid the mess of using only two version numbers, this package hasn't been touched in 3 years, looks moderately stable.
I see there are these drone CI running on Julia 1.3 - 1.5, can I remove it safely?
There was a problem hiding this comment.
The Drone service is completely broken, just remove it.
There was a problem hiding this comment.
I also remove AppVeyor as the service in Julia is unmaintained and version still refers to 1.5
|
except for appveyor build failing, all tests pass. is there a reason not to merge? |
|
I think the issues in JuliaIO/VideoIO.jl#418 are resolved. It seems newer FFMPEG just returns greater precision for duration queries. |
5 participants
Updated compat and removed avresample reference: https://bugs.gentoo.org/722274